New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Super user filter in tinymce #11022
Conversation
I have tested this item 🔴 unsuccessfully on f85ad0e But after applying the patch and toggling the editor and pasting the following code When I toggle the editor back on and then off again it shows `
123-456-6789 `Note the extra < p > This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
That's (sadly) a standard behavior in the tinymce. If you toggle the editor (to html) insert some text, toggle it back and look again, it also added the See also: https://www.tinymce.com/docs/configure/content-filtering/#forced_root_block |
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
I have tested this item ✅ successfully on 7fd9073 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
@brianteeman if you turn off |
@bembelimen either i don't get the PR or you interchanged true and false. Not working for me. Added some var_dumps and the output of verify_html for your reference: |
Hi @yvesh |
Okay, sorry my fault. Should read the instruction properly (forgot switching to joomla filter in plugin settings). |
I have tested this item ✅ successfully on 7fd9073 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
@wilsonge can you merge this? |
Rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022. |
@joomla-cms-bot you record i need to call you twice on one issue for that label thing :P |
Pull Request for Issue #11020 .
Summary of Changes
This patch deactivates the TinyMCE filtering, if the editor has "No filtering" in the global configuration (Tab Text filter)
Testing Instructions
<span class="fa fa-phone fa-3x sr-contact"></span> <p>123-456-6789</p>
to a article=> Code is removed