Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Super user filter in tinymce #11022

Merged
merged 2 commits into from Jul 16, 2016
Merged

Fix Super user filter in tinymce #11022

merged 2 commits into from Jul 16, 2016

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Jul 4, 2016

Pull Request for Issue #11020 .

Summary of Changes

This patch deactivates the TinyMCE filtering, if the editor has "No filtering" in the global configuration (Tab Text filter)

Testing Instructions

  • Login as Super User
  • Make sure, you have "No filtering" in the text filter settings (global config)
  • Switch the filter in the tinymce plugin to "Use Joomla text filter"
  • Add <span class="fa fa-phone fa-3x sr-contact"></span> <p>123-456-6789</p> to a article
  • Toggle editor
    => Code is removed
  • Apply patch
  • Try again

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on f85ad0e

I can confirm the issue as reported

But after applying the patch and toggling the editor and pasting the following code
<span class="fa fa-phone fa-3x sr-contact"></span> <p>123-456-6789</p>

When I toggle the editor back on and then off again it shows

`

123-456-6789

`

Note the extra < p >


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@bembelimen
Copy link
Contributor Author

bembelimen commented Jul 4, 2016

That's (sadly) a standard behavior in the tinymce. If you toggle the editor (to html) insert some text, toggle it back and look again, it also added the <p>

See also: https://www.tinymce.com/docs/configure/content-filtering/#forced_root_block

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@coolcat-creations
Copy link
Contributor

I have tested this item ✅ successfully on 7fd9073


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@coolcat-creations
Copy link
Contributor

coolcat-creations commented Jul 4, 2016

@brianteeman if you turn off <p> for new lines in the tinyMCE Plugin it doesn´t add the additional p
I see this fix as important to be merged because otherwise everything is striped by default?

@yvesh
Copy link
Member

yvesh commented Jul 4, 2016

@bembelimen either i don't get the PR or you interchanged true and false. Not working for me.

Added some var_dumps and the output of verify_html for your reference:

screenshot 2016-07-04 21 36 29

@bembelimen
Copy link
Contributor Author

bembelimen commented Jul 4, 2016

Hi @yvesh
It's a bit tricky: to deactivate the filtering in the TinyMCE, you have to set verify_html to "false".
So if $ignore_filter is "true", I had to flip verify_html to false. And ofc the other way arround, too.

@yvesh
Copy link
Member

yvesh commented Jul 4, 2016

Okay, sorry my fault. Should read the instruction properly (forgot switching to joomla filter in plugin settings).

@yvesh
Copy link
Member

yvesh commented Jul 4, 2016

I have tested this item ✅ successfully on 7fd9073

Works fine, thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@coolcat-creations
Copy link
Contributor

@wilsonge can you merge this?

@brianteeman
Copy link
Contributor

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 4, 2016
@zero-24
Copy link
Member

zero-24 commented Jul 4, 2016

@joomla-cms-bot :P


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11022.

@brianteeman brianteeman added this to the Joomla 3.6.1 milestone Jul 12, 2016
@roland-d roland-d merged commit 14098e7 into joomla:staging Jul 16, 2016
@zero-24
Copy link
Member

zero-24 commented Jul 21, 2016

@joomla-cms-bot you record i need to call you twice on one issue for that label thing :P

@roland-d roland-d removed the RTC This Pull Request is Ready To Commit label Jul 22, 2016
@bembelimen bembelimen deleted the patch-3 branch May 15, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants