Use correct parameter type (Fix #11082)

[mbabker]

Pull Request for Issue #11082

Summary of Changes

The third parameter is typehinted as an array so passing a null value is not allowed. Pass an array instead.

Testing Instructions

Code review.

[dgrammatiko]

I have tested this item ✅ successfully on b47f466

On review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11086.}

[andrepereiradasilva]

I have tested this item ✅ successfully on b47f466

on code review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11086.}

[dgrammatiko]

RTC

[hkingman]

The same change is needed on line 488 of the same file (file.php)

[brianteeman]

@hkimgman - please create a new issue or even better a pull request.
CComments on closed Pull Releases will not get seen

[hkingman]

Thank you, will do

On Tue, Aug 2, 2016 at 12:53 PM, Brian Teeman notifications@github.com
wrote:

@hkimgman - please create a new issue or even better a pull request.
CComments on closed Pull Releases will not get seen

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11086 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCw0nsTN-6nvWZpRm1NwkLW1n4VLEwLks5qb6AngaJpZM4JK6wt
.

Henry Kingman
Winnemucca Web Works, LLC
http://WinWebWorks.com/
775 375-8293
henry@winwebworks.com

[hakanara]

Hi. I cannot upgrade any of my sites from 3.6.0 to 3.6.1 because as @hkingman states line 488 needs a change as well. I get this error:

Catchable fatal error: Argument 3 passed to JClientFtp::getInstance() must be of the type array, null given, called in /libraries/joomla/filesystem/file.php on line 488 and defined in /libraries/joomla/client/ftp.php on line 194

Edit: Disabling the FTP layer in site configuration solved the issue so that I managed to upgrade.

[hkingman]

just change null to array() on line 488. The change was pulled, but I guess
it didn't make it into 3.6.0

On Aug 4, 2016 1:25 AM, "hakanara" notifications@github.com wrote:

Hi. I cannot upgrade any of my sites from 3.6.0 to 3.6.1 because as
hkingman states line 488 needs a change as well. I get this error:

Catchable fatal error: Argument 3 passed to JClientFtp::getInstance() must
be of the type array, null given, called in /libraries/joomla/filesystem/file.php
on line 488 and defined in /libraries/joomla/client/ftp.php on line 194

Shall I wait for a new update? Even though a new update comes, I cannot
patch it since the updater does not work. I am not sure how to proceed.
Please advise. This situation affects more than 5 sites.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11086 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCw0vLLKK4GD2hvH-I3grCsGi4Clz2Aks5qcaHbgaJpZM4JK6wt
.

[zero-24]

but I guess it didn't make it into 3.6.0

how could this be done ;) It is shipped with 3.6.1