Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip of modified by #11145

Merged
merged 4 commits into from
Jul 21, 2016
Merged

Add tooltip of modified by #11145

merged 4 commits into from
Jul 21, 2016

Conversation

RonakParmar
Copy link

@RonakParmar RonakParmar commented Jul 15, 2016 •
edited by brianteeman

Summary of Changes

Added tooltip for "Modified by" field in Banner, Contact and Newsfeed page.

Testing Instructions

  • Login at administrator side.
  • Check banner, contact and newsfeed new/edit page->Publishing tag ->Modified by field.
    There is no tooltip for this field.
    Apply this PR and follow above steps, you can see tooltip for this field.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 15, 2016
@RonakParmar
Copy link
Author

You can see tooltip for "Modified by" field of Article, Category and Tag new/edit page in this PR #11144 . @kalpeshtailored has already added tooltip for this field for these pages.

@killoltailored
Copy link

I have tested this item ✅ successfully on 0668e83

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

andrepereiradasilva
andrepereiradasilva reviewed Jul 15, 2016
View reviewed changes
administrator/language/en-GB/en-GB.com_contact.ini
@@ -291,6 +291,7 @@ COM_CONTACT_WARNING_PROVIDE_VALID_NAME="Please provide a valid name."
COM_CONTACT_WARNING_PROVIDE_VALID_URL="Please provide a valid URL."
COM_CONTACT_WARNING_SELECT_CONTACT_TOPUBLISH="Please select a contact to publish."
COM_CONTACT_XML_DESCRIPTION="This component shows a listing of contact information."
COM_CONTACT_FIELD_MODIFIED_BY_DESC="Name of the user who modified this contact."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please alpha order language strings

@ghost
Copy link

ghost commented Jul 18, 2016

I have tested this item ✅ successfully on 0668e83

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@tomartailored
Copy link

I have tested this item ✅ successfully on 0668e83

I have tested this item successfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 1c0bc49

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

brianteeman
brianteeman reviewed Jul 20, 2016
View reviewed changes
administrator/language/en-GB/en-GB.com_newsfeeds.ini
@@ -44,6 +44,7 @@ COM_NEWSFEEDS_FIELD_IMAGE_CAPTION_LABEL="Caption"
COM_NEWSFEEDS_FIELD_LANGUAGE_DESC="Assign a language to this news feed."
COM_NEWSFEEDS_FIELD_LINK_DESC="Link to the news feed. IDN (International) Links are converted to punycode when they are saved."
COM_NEWSFEEDS_FIELD_LINK_LABEL="Link"
COM_NEWSFEEDS_FIELD_MODIFIED_BY_DESC="Name of the user who modified this newsfeed."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to news feed - two words https://joomla.github.io/user-interface-text/?user-interface-text/words2watch.md

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 1c0bc49

Please make sure newsfeed is written as two words https://joomla.github.io/user-interface-text/?user-interface-text/words2watch.md

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 1c0bc49

Please make sure newsfeed is written as two words https://joomla.github.io/user-interface-text/?user-interface-text/words2watch.md

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@NeerajTailored
Copy link

I have tested this item ✅ successfully on fca1f9e

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

1 similar comment
@JamalTailored
Copy link

I have tested this item ✅ successfully on fca1f9e

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@brianteeman
Copy link
Contributor

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@brianteeman brianteeman added this to the Joomla 3.6.1 milestone Jul 21, 2016
@truptikagathara
Copy link

I have tested this item ✅ successfully on fca1f9e

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11145.

@wilsonge wilsonge merged commit 69a4a7f into joomla:staging Jul 21, 2016
@zero-24
Copy link
Contributor

zero-24 commented Jul 21, 2016

@joomla-cms-bot are you sleeping now?

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Language Change This is for Translators
Projects
None yet
Milestone
Joomla 3.6.1
Development

Successfully merging this pull request may close these issues.

None yet