Use alert-link class, change link color for default warning alert #11209
Conversation
| @@ -55,7 +55,7 @@ COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_CUSTOM="You are on the "%s" | |||
| COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_DEFAULT="You are on the "%s" update channel. Through this channel you'll receive notifications for all updates of the current Joomla release (3.x)" | |||
| COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_NEXT="You are on the "%s" update channel. Through this channel you'll receive notifications for all updates of the current Joomla release (3.x) and you will also be notified when the future major release (4.x) will be available. Before upgrading to 4.x you'll need to assess its compatibility with your environment." | |||
| COM_JOOMLAUPDATE_VIEW_DEFAULT_UPDATES_INFO_TESTING="You are on the "%s" update channel. This channel is designed for testing new releases and fixes in Joomla.<br />It is only intended for JBS (Joomla Bug Squad™) members and others within the Joomla community who are testing. Do not use this setting on a production site." | |||
| COM_JOOMLAUPDATE_VIEW_DEFAULT_UPLOAD_INTRO="You can use this feature to update Joomla if your server is behind a firewall or otherwise unable to contact the update servers. First download the Joomla <em>Upgrade Package</em> in ZIP format from <a href=\"%s\">the official Joomla download page</a>. Then use the fields below to upload and install it." | |||
| COM_JOOMLAUPDATE_VIEW_DEFAULT_UPLOAD_INTRO="You can use this feature to update Joomla if your server is behind a firewall or otherwise unable to contact the update servers. First download the Joomla <em>Upgrade Package</em> in ZIP format from <a class=\"alert-link\" href=\"%s\">the official Joomla download page</a>. Then use the fields below to upload and install it." | |||
There was a problem hiding this comment.
\" 💯
So someone needs to do a huge find and replace 😄
|
I have tested this item ✅ successfully on 0012d07 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
I have tested for "Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output.". This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
I have tested this item ✅ successfully on 0012d07 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
Tested successfully for "stats plugin's nag message and duplicate queries in the debug console's output" This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
Where I can see the above warning message which you have displayed in screen-dump in description? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
@zero-24 Thank you for the Link, but How to test this link after applying the PR? I have replicated latest staging site in my local system and using patch tester component I am testing all PRs. |
|
@RonakParmar this screenshot was just an example how it looks like ;) for testing you can have a look to the |
|
Okay got it, Apologize for the misunderstanding, Then I have already tested using system debug console. Thanks for the clarification @zero-24 👍 |
|
I have tested this item ✅ successfully on 0012d07 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11209. |
Summary of Changes
Consistently use recently introduced
alert-linkclass for all links in rendered alert divs. Also, changes the color of alert links for the default warning alert div to match its color (and Bootstrap 3's implementation)Before:
After:
Testing Instructions
In the update component, the link to the download page should now have the "bold" appearance. Same for the link in the stats plugin's nag message and duplicate queries in the debug console's output. Links in warning alerts (default yellow) should now have the brownish appearance instead of blue.
As for the stray CSS change with the
.categories-list .collapseselector, that came after running thegeneratecss.phpscript. No idea why else it'd be there.