Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[associations helper] Use JLoader to load the router to make association links #11321

Merged

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Jul 27, 2016

Summary of Changes

The component router helper should be registered in the component association helper so when loading the helper it's already auto-loaded.
So we drop jimport and use JLoader::register

Testing Instructions

In multilanguage site, component items Associations tabs work fine (business as usual) in all core components (com_content, com_contact and com_newsfeeds) that supports associations (excluding com_menus that does not need this).

Notes

This issue was discovered in the GsoC multilingual association sproject.

Note: a similiar PR will be made for com_weblinks repository.

@infograf768 @alikon @jreys please test

@alikon
Copy link
Contributor

alikon commented Jul 27, 2016

I have tested this item ✅ successfully on 8b181d7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

1 similar comment
@jreys
Copy link
Contributor

jreys commented Jul 27, 2016

I have tested this item ✅ successfully on 8b181d7


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

@infograf768
Copy link
Member

rtc.
@wilsonge can we get that in 3.6.1 ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11321.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 27, 2016
@wilsonge wilsonge merged commit 9c11f8c into joomla:staging Jul 27, 2016
@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 27, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 27, 2016
@andrepereiradasilva andrepereiradasilva deleted the correct-route-association branch July 27, 2016 18:50
@ggppdk
Copy link
Contributor

ggppdk commented Jul 27, 2016

I have made same update to my extension association helper, works there too

@andrepereiradasilva
Copy link
Contributor Author

BTW does your extension supports associations?
If so, can you post a link here: joomla-projects/gsoc16_improved-multi-lingual#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants