Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer libraries #11334

Merged
merged 2 commits into from Aug 13, 2016
Merged

Update composer libraries #11334

merged 2 commits into from Aug 13, 2016

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jul 28, 2016

Pull Request for Issue #10835 .

Summary of Changes

Updates phpmailer, joomla registry, symfony polyfill (php 5.6), symfony yaml to their latest versions

Testing Instructions

Registry is used everywhere. So navigate around and check for errors. Yaml isn't used by core. If possible test in PHP < 5.6 to test the polyfill and check emails still send for phpmailer.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e716894

Seems ok - sendtestmail still works. No errors navigating around. Not sure what polyfil is used for


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@wilsonge
Copy link
Contributor Author

The 5.6 polyfill is used to make the hash_equals function available on PHP 5.3, 5.4 and 5.5. So check logging in with passwords still works properly on those php versions

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on e716894

OK something went wrong.
Admin is fine but front end fails to load with this in the logs

Call to a member function getDefault() on a non-object in libraries/cms/router/site.php on line 266


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@brianteeman
Copy link
Contributor

Under php7 I get

Error displaying the error page: Call to a member function getActive() on null: Call to a member function getDefault() on null


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@wilsonge
Copy link
Contributor Author

wilsonge commented Jul 30, 2016

Woohoo so Joomla's been shipping sample data with invalid JSON since 2012 - we just never had error handling :P Fixed for existing data sets and dealt with the invalid JSON

@brianteeman
Copy link
Contributor

The error on the homepage has gone now

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4c258c5

Tested creating users and logging in under multiple php versions 5.4, 5.5, 5.6, 7
Tested sending mail using the testmail function in global config


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 4c258c5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11334.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 3, 2016
@wilsonge wilsonge added this to the Joomla 3.6.2 milestone Aug 3, 2016
@mbabker
Copy link
Contributor

mbabker commented Aug 8, 2016

@wilsonge What version of Composer do you have? Current Composer versions are generating a autoload_static.php file which isn't added in this PR.

@wilsonge
Copy link
Contributor Author

wilsonge commented Aug 8, 2016

Georges-MacBook-Pro:~ george$ composer --version
Composer version 1.0.2 2016-04-21 12:30:18

Just updated to 1.2.0

@mbabker
Copy link
Contributor

mbabker commented Aug 8, 2016

About time! 😜

@rdeutz rdeutz merged commit 68eef29 into joomla:staging Aug 13, 2016
@wilsonge wilsonge deleted the composer-update branch August 13, 2016 17:38
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
* Update composer libraries

* Fix sample testing data json
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* Update composer libraries

* Fix sample testing data json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants