[com_menus] New menu item. Force client in menu item parent to not show admin menus

[andrepereiradasilva]

Pull Request for New Issue.

Summary of Changes

Another joomla cms bug was discovered in joomla gsoc multilangue project.
When creating a new menu item without menu type selected the parent id select box shows all site AND admin menus!
This PR intends to solves that.

Testing Instructions

1. Use latest staging
2. Logout
3. Login in Admin and go directy to Menus -> All Menu Items
4. Click New
5. Check the parent menu selector. you will see something like this
   
6. Apply patch
7. Do the same tests, check all is fine
8. Test creating/editing menu items to make sure nothing is breaked
9. Code review

@infograf768 @jreys @alikon

[infograf768]

I have tested this item ✅ successfully on

This works fine.

The issue is a side effect of the new All menu items PR as, before that, the Menu field was always filled and we got the right possible parents.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.}

[jreys]

I have tested this item ✅ successfully on 0736965

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.}

[brianteeman]

I thought I couldnt replicate this but it only happens if you do step 3

On 29 July 2016 at 17:33, andrepereiradasilva notifications@github.com
wrote:

Pull Request for New Issue.
Summary of Changes

Another byg was discovered in joomla gsoc multilangue project.
When creating a new menu item without menu type selected the parent id
select box shows all site AND admin menus!
Thsi PR solves that.
Testing Instructions

1. Use latest staging
2. Logout
3. Login in Admin and go directy to Menus -> All Menu Items
4. Click New
5. Check the parent menu selector. you will see something like this [image:
   image]
   https://cloud.githubusercontent.com/assets/9630530/17255703/3bc8942c-55b2-11e6-8b59-88fa2176bc89.png
6. Apply patch
7. Do the same tests, check all is fine
8. Test creating/editing menu items to make sure nothing is breaked
9. Code review

---

You can view, comment on, or merge this pull request online at:

#11355
Commit Summary

• force client in menu item parent

File Changes

• M administrator/components/com_menus/models/fields/menuparent.php
  https://github.com/joomla/joomla-cms/pull/11355/files#diff-0 (9)
• M administrator/components/com_menus/models/forms/item.xml
  https://github.com/joomla/joomla-cms/pull/11355/files#diff-1 (1)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/11355.patch
• https://github.com/joomla/joomla-cms/pull/11355.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11355, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cPXsSDXB-c_fXNnyWzB7jR8sM3Lks5qaitngaJpZM4JYXGu
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[andrepereiradasilva]

yeah, it happens when you don't have any menu type in user state. that's why i say in test instructions to logout.

[brianteeman]

I have tested this item ✅ successfully on 0736965

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.}

[infograf768]

@wilsonge
This is totally B/C.

[andrepereiradasilva]

3.6.2 milestone?

[andrepereiradasilva]

ok it's 3.6.3 sorry

[alikon]

unable to mark successfull test on issues.joomla.org

[brianteeman]

@alikon I can do it for you if needed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11355.}

[alikon]

thanks brian
there is no need as it is already RTC

p.s.
grrr i'm still experiencing "strange" issues with issues.joomla.org 😢

[brianteeman]

We all are @alikon :(