Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing commas #11362

Merged
merged 1 commit into from
Jul 30, 2016
Merged

Missing commas #11362

merged 1 commit into from
Jul 30, 2016

Conversation

demis-palma
Copy link
Contributor

@demis-palma demis-palma commented Jul 29, 2016

The problem regards RTL css. Looking at the corresponding LTR css, it's clear that a few commas went lost.

@jeckodevelopment
Copy link
Member

jeckodevelopment commented Jul 30, 2016

I have tested this item ✅ successfully on 6c89cea

@MATsxm
Copy link

MATsxm commented Jul 30, 2016

I have tested this item ✅ successfully on 6c89cea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11362.

@mbabker
Copy link
Contributor

mbabker commented Jul 30, 2016

At least with Isis there should be a corresponding LESS file (I don't think
I ever got to LESS for RTL in Hathor). Can you make sure there isn't a
LESS file that needs correcting?

On Friday, July 29, 2016, Demis Palma ツ notifications@github.com wrote:

The problem regards RTL css. Looking at the corresponding LTR css, it's

clear that a few commas went lost.

You can view, comment on, or merge this pull request online at:

#11362
Commit Summary

  • Fixed commas

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11362, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVH_J55N3CaAFQDxhivxre-HuxErks5qapBwgaJpZM4JYqXT
.

@demis-palma
Copy link
Contributor Author

demis-palma commented Jul 30, 2016

I'll take a look and let you know.

@Lavsteph
Copy link

I have tested this item ✅ successfully on 6c89cea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11362.

@brianteeman
Copy link
Contributor

There is no RTL less file for hathor

@brianteeman
Copy link
Contributor

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11362.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@wilsonge wilsonge merged commit 7a68a5d into joomla:staging Jul 30, 2016
@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 30, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@wojsmol
Copy link
Contributor

wojsmol commented Jul 30, 2016

@brianteeman

There is no RTL less file for hathor

but there is for isis RTL, prepering PR.

@wojsmol
Copy link
Contributor

wojsmol commented Jul 30, 2016

@demis-palma demis-palma deleted the missing-comma-1 branch March 30, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants