Remove insert module button

[brianteeman]

Pull Request for Issue #10525 .

Based on feedback in #10539
This PR removes the ability to insert a module into
Contact Form information
Tag description
Category description
Banner Description

Testing Instructions

Open above forms and see that the module button is not present in the tinymce toolbar

[andrepereiradasilva]

i still don't understand why a user can't put a module (for instance with a map) inside a contact form ...

[brianteeman]

well it doesnt work for one ;)

[andrepereiradasilva]

did you test? it does work now after @ggppdk PR see #10541

[brianteeman]

oops
So is it just a bug still with banners?

[andrepereiradasilva]

don't know

[brianteeman]

No. Now that it works I will update the Pr. Is it still a problem with
banners?

On 3 Aug 2016 6:12 p.m., "andrepereiradasilva" notifications@github.com
wrote:

i still don't understand why a user can't put a module (for instance with
a map) inside a contact form ...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WkRZ8wk9OFEuro-QWDdOzFV8Mehks5qcMnigaJpZM4Jb0lR
.

[brianteeman]

I removed the one for contacts

For banners as far as I can see the editor is for an internal administrator only description so as the plugin will never be processed in the admin it makes no sense

[JoshJourney]

I'm curious why not instead make the module work inside of a banner? Bad practice?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}

[brianteeman]

As i stated - unless I am missing something the only place the text area
involved for banners is ever displayed is as an INTERNAL note in the admin
area. content-plugins are not processed there

On 3 August 2016 at 23:32, Josh Lewis notifications@github.com wrote:

I'm curious why not instead make the module work inside of a banner? Bad

practice?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11419
https://issues.joomla.org/tracker/joomla-cms/11419.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RokXe62L-O5v02OWihNwrwBk8Skks5qcRcTgaJpZM4Jb0lR
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[JoshJourney]

I have tested this item ✅ successfully on d092e6c

Fair enough. The PR works as expected. :-)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}

[hardiktailored]

@brianteeman Module button removed from Banners Description but it still visible in Banners Category Description. Is that intended?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}

[JoshJourney]

@hardiktailored If plugins cannot be processed in a banner category description, then no. However I think it's safe to assume that scenario was not covered in this PR. Either this PR could be modified to accommodate that scenario or an additional PR can be made. I'd be happy to test either way.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}

[brianteeman]

yes it was intended to not remove it and allow it in the category
description. The category description can be displayed on the front end
where inserting a module will work

On 5 August 2016 at 07:29, Josh Lewis notifications@github.com wrote:

@hardiktailored https://github.com/hardiktailored If plugins cannot be
processed in a banner category description, then no. However I think it's
safe to assume that scenario was not covered in this PR. Either this PR
could be modified to accommodate that scenario or an additional PR can be

made. I'd be happy to test either way.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11419
https://issues.joomla.org/tracker/joomla-cms/11419.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11419 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R9UOqJRvSNmawwioXYTVtMKYRNXks5qctgxgaJpZM4Jb0lR
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[hardiktailored]

I have tested this item ✅ successfully on d092e6c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}

[brianteeman]

RTC - thanks for testing

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11419.}