Email cloaking unit tests #11462
Merged
Email cloaking unit tests #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2016 22:56
Further work forked from #4071
| JFactory::$session = $this->getMockSession(); | ||
|
|
||
| // force the cloak JS inline so that we can unit test it easier than messing with script head in document | ||
| JFactory::getApplication()->input->server->set('HTTP_X_REQUESTED_WITH', 'xmlhttprequest'); |
There was a problem hiding this comment.
This will probably fail as you have a mock JApplicationCms object rather than the real thing
There was a problem hiding this comment.
I knew you could do it if you wanted to
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Love it! |
This comment was marked as abuse.
This comment was marked as abuse.
|
Hope these links help to collect a list of scenario to test |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
As this doesn't affect any production code I'm merging this to run with it over the weekend. Thanks for picking up on that old code Phil!! |
This comment was marked as abuse.
This comment was marked as abuse.
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
* Unit Test init for Email Cloaking Further work forked from joomla#4071 * Example assertions * Tidy up, documentation * Implement a JS to HTML converter to allow easy unit testing of outputs * Add test for joomla#11378 as an example & more documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork/rebase/redoing of the great work started by @wilsonge in #4071
**incomplete - but creating the PR so that travis can start to churn the tests **