Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate login and logout forms in beez3 template #11531

Merged
merged 2 commits into from Aug 13, 2016
Merged

Conversation

jo-sf
Copy link
Contributor

@jo-sf jo-sf commented Aug 9, 2016

About 4 years ago the login and logout forms have been separated in modules/mod_login/tmpl, but this separation never made its way into the beez3 template. This PR will change this...

Testing Instructions

For testing this change you need a current Joomla installation with the sample data installed.

Status Quo

  • open the site homepage
  • locate the menu "A Deep Menu" (on the right side, scroll down)
  • click on "Using Joomla!"
  • again locate the menu "A Deep Menu" and click on "Using Extensions"
  • click on the "Templates" link in the middle of the screen
  • click on the "Home Page" link below "Beez 20" in the middle of the screen
  • the next page is shown using the "beez3" template
  • scroll down and locate the "Login Form" (on the left side)
  • notice that the text "Log in" at the button is blue
  • log in using any valid user name and password
  • again scroll down and locate the "Login Form" (same place as before)
  • notice that the text "Log out" at the button is black
  • press the "Log out" button
  • click on the "Beez 2" link in the breadcrumb line

Changes

  • install this PR
  • click on the "Home page" link in the article area (I assume that you're still at the page from the end of the "Status Quo" test instructions)
  • again locate the "Login form" and notice that it looks as before, including the blue "Log in" text
  • log in using any valid user name and password
  • again scroll down and locate the "Login Form"
  • notice that the logout form looks nearly the same as before, the only change is that the "Log out" text is now blue
  • press the "Log out" button

Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl
Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl
@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 94f777d

just change the default template to beez3 in template manager and made the test
works as described


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11531.

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 94f777d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11531.

1 similar comment
@truptikagathara
Copy link

I have tested this item ✅ successfully on 94f777d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11531.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11531.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 10, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 10, 2016
@rdeutz rdeutz merged commit 3c06570 into joomla:staging Aug 13, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
* Separate login and logout forms

Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl

* Separate login and logout forms

Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* Separate login and logout forms

Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl

* Separate login and logout forms

Separate login and logout forms as has been done about 4 years ago in modules/mod_login/tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants