Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror updated to 5.18.0 #11752

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Conversation

okonomiyaki3000
Copy link
Contributor

@okonomiyaki3000 okonomiyaki3000 commented Aug 23, 2016

Pull Request for Issue # .

Summary of Changes

http://codemirror.net/doc/releases.html

Testing Instructions

Just use CodeMirror and expect it to work as usual or better.

Documentation Changes Required

Nope.

@brianteeman
Copy link
Contributor

Thanks for doing this again

One step that we just realised you havent been doing is what to do when files are deleted. If a file is removed then it should be added to https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11752.

@okonomiyaki3000
Copy link
Contributor Author

Ah, I suppose that would be the Jade mode.

@brianteeman
Copy link
Contributor

Thank you

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 360f4ee


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11752.

1 similar comment
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 360f4ee


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11752.

@zero-24
Copy link
Contributor

zero-24 commented Aug 23, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11752.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 23, 2016
@wilsonge wilsonge merged commit 28512e8 into joomla:staging Aug 23, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 23, 2016
@okonomiyaki3000 okonomiyaki3000 deleted the CodeMirrorUpdate branch August 25, 2016 00:16
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* CodeMirror updated to 5.18.0

* the Jade mode was removed. Now called Pug instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants