Improve warning message if article author no longer exists

[C-Lodder]

Steps to reproduce the issue

• Create a new user
• Create an article and set the Author as the newly created user
• Delete the user
• Open the Article in the Article Manager

Expected result

I would suggest displaying a more meaningful message, such as:

The author of this article no longer exist.

Or something along those lines. @brianteeman perhaps you could come up with a better warning message

Actual result

JUser: :_load: Unable to load user with ID: 371

[brianteeman]

How about "The author of this article is no longer a user on this site" But also please check if it is just the created user that generates this error - perhaps the modified user does as well - I dont remember

[C-Lodder]

Not really sure how to approach this. The message is coming from here:

https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/user/user.php#L869

Only thing I can think of is using JInput and a conditional statement:

$input = JFactory::getApplication()->input;

if ($input->get('layout') == 'edit')
{
    JLog::add(JText::_('The author of this article is no longer a user on this site'), JLog::WARNING, 'jerror');
}
else
{
    JLog::add(JText::sprintf('JLIB_USER_ERROR_UNABLE_TO_LOAD_USER', $id), JLog::WARNING, 'jerror');
}

which I'm not sure is the best method.

@mbabker - any thoughts on how to approach this?

[mbabker]

I would not be putting component specific stuff in JUser for starters. This is why arbitrarily logging things with the "jerror" category isn't a good mechanism of error handling. It'd be better if it threw an Exception but that apparently has B/C implications. So the only way around that would be to stop logging to the "jerror" category and force downstream uses of JUser::load() to check for boolean false conditions and implement their own error handling mechanisms at a lower level (to include rendering a "friendly" message).

As vague as it is, the error message generated at the spot it is now is correct and even if it were throwing an Exception I wouldn't change it. Annoying because it's vague and generally not friendly, but this is a case of an error being rendered where it shouldn't be and it does actually state what the error condition is (can't load a user with the given ID) but it's not really pertinent to every site visitor.

[C-Lodder]

Ok thanks @mbabker . Closing