Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories correct ordering with pagination #11906

Merged
merged 3 commits into from Aug 18, 2017
Merged

Categories correct ordering with pagination #11906

merged 3 commits into from Aug 18, 2017

Conversation

t-arapi
Copy link
Contributor

@t-arapi t-arapi commented Sep 3, 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Documentation Changes Required

@brianteeman
Copy link
Contributor

Please describe the problem this pr fixes. How to replicate the bug and how to test the fix

@t-arapi
Copy link
Contributor Author

t-arapi commented Sep 3, 2016

When you order all the items, there's no problem, but when i try to put a different pagination order (like for example when i try o put another order, 5 or 10 for pagination, the 1st page is correct, but the other ones are not accurate, as they change the order without me knowing, like they go randomly)
This is a file that shows what I mean:
aaaa

@brianteeman
Copy link
Contributor

Sorry that shows nothing

@t-arapi
Copy link
Contributor Author

t-arapi commented Sep 3, 2016

Category list:

total

First page 5 items:

p1

Second page:

p2

@brianteeman
Copy link
Contributor

Sorry but I still cannot see what is wrong


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@jeckodevelopment
Copy link
Member

@t-arapi can you please create an animation that shows the issue? because screenshots are not so clear

@t-arapi
Copy link
Contributor Author

t-arapi commented Sep 4, 2016

  1. Create 7 categories
  2. Show content categories diplay all
  3. Reorder all cats (remember the order)
  4. Show content categories limit 5 (pagination has 2 pages)
  5. Go to page 2 and order up the last item
  6. Show content categories diplay all
  7. Check up the order that you have now and if it is the same as the previous one

Does this help somehow?

@brianteeman
Copy link
Contributor

I think I have replicated it - is this what you meant

cats

@t-arapi
Copy link
Contributor Author

t-arapi commented Sep 4, 2016

Yes, more or less, although the category number 9 should be the sixth in the final order and not the fisrt.

@brianteeman
Copy link
Contributor

Yes that's the bug?

On 4 Sep 2016 3:34 p.m., "t-arapi" notifications@github.com wrote:

Yes, more or less, although the category number 9 should be the sixth in
the final order and not the fisrt.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11906 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZI0dPYlGTUJPNT5TYJgxbT-c7Mpks5qmtcFgaJpZM4J0Rlm
.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 508b3f4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@AnishaTailored
Copy link

I have tested this item ✅ successfully on d6b66a5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

1 similar comment
@truptikagathara
Copy link

I have tested this item ✅ successfully on d6b66a5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 6, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Sep 6, 2016
@rdeutz
Copy link
Contributor

rdeutz commented Sep 6, 2016

This needs more testing, I am not 100% sure that the fix is ok and doesn't have side effects.

@rdeutz rdeutz self-assigned this Sep 6, 2016
@rdeutz
Copy link
Contributor

rdeutz commented Sep 6, 2016

set to needs review since we have tested this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2016
@tomartailored
Copy link

I have tested this item ✅ successfully on d6b66a5

yes , i have tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906.

@brianteeman brianteeman removed this from the Joomla 3.6.3 milestone Sep 6, 2016
@brianteeman
Copy link
Contributor

Removed the milestone for now

@brianteeman
Copy link
Contributor

@rdeutz have you done a review?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

@roland-d
Copy link
Contributor

nudging @rdeutz

@ghost
Copy link

ghost commented Jun 22, 2017

maybe @rdeutz is enough.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

@ghost
Copy link

ghost commented Aug 18, 2017

If this PR get no Response, it will be closed at 17th September 2017.

@brianteeman
Copy link
Contributor

@franz-wohlkoenig this PR is waiting a review from a maintainer. It has been tested by several people as good but @rdeutz wanted to hold back on merging it so he could do further tests. It shouldnt be closed just because a maintainer hasnt approved/merged it

@rdeutz rdeutz removed their assignment Aug 18, 2017
@rdeutz rdeutz added this to the Joomla 3.8.0 milestone Aug 18, 2017
@ghost
Copy link

ghost commented Aug 18, 2017

thanks for Info @brianteeman and thanks for approve @rdeutz

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.0 milestone Aug 18, 2017
@rdeutz
Copy link
Contributor

rdeutz commented Aug 18, 2017

just go ahead with this, @mbabker can make the decision


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2017
@mbabker mbabker merged commit 7e89ab4 into joomla:staging Aug 18, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2017
@brianteeman
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet