New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categories correct ordering with pagination #11906
Conversation
Please describe the problem this pr fixes. How to replicate the bug and how to test the fix |
Sorry that shows nothing |
Sorry but I still cannot see what is wrong This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
@t-arapi can you please create an animation that shows the issue? because screenshots are not so clear |
Does this help somehow? |
Yes, more or less, although the category number 9 should be the sixth in the final order and not the fisrt. |
Yes that's the bug? On 4 Sep 2016 3:34 p.m., "t-arapi" notifications@github.com wrote:
|
I have tested this item ✅ successfully on 508b3f4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
I have tested this item ✅ successfully on d6b66a5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
1 similar comment
I have tested this item ✅ successfully on d6b66a5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
This needs more testing, I am not 100% sure that the fix is ok and doesn't have side effects. |
set to needs review since we have tested this This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
I have tested this item ✅ successfully on d6b66a5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11906. |
Removed the milestone for now |
@rdeutz have you done a review? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906. |
nudging @rdeutz |
maybe @rdeutz is enough. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906. |
If this PR get no Response, it will be closed at 17th September 2017. |
@franz-wohlkoenig this PR is waiting a review from a maintainer. It has been tested by several people as good but @rdeutz wanted to hold back on merging it so he could do further tests. It shouldnt be closed just because a maintainer hasnt approved/merged it |
thanks for Info @brianteeman and thanks for approve @rdeutz |
just go ahead with this, @mbabker can make the decision This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11906. |
Thanks |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Documentation Changes Required