Reduce the number of page duplicates in com_content categories when pagination is used.

[philip-sorokin]

Summary of Changes

Reduce the number of page duplicates in com_content categories when pagination is used.

Testing Instructions

https://www.joomla.org/announcements.html?start=999999999999999999999 - it opens, while it should not. With this patch applied, pages will open if they really exist: https://www.joomla.org/announcements.html?start=390 - this will be the last page.

[zero-24]

@ADDONDEV can you fix the if syntax and add a space bettween the if and the openeing (

FILE: ...ld/joomla/joomla-cms/components/com_content/views/archive/view.html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 86 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found
    |       | "if(...)\n...{...}\n...else\n"
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...d/joomla/joomla-cms/components/com_content/views/category/view.html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 125 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found
     |       | "if(...)\n...{...}\n...else\n"
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...d/joomla/joomla-cms/components/com_content/views/featured/view.html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 117 | ERROR | Expected "if (...)\n...{...}\n...else\n"; found
     |       | "if(...)\n...{...}\n...else\n"
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

https://travis-ci.org/joomla/joomla-cms/jobs/159016449

[philip-sorokin]

Can you test it, please?

[brianteeman]

Is it the intended behaviour of this pr that ?start=999999999999999999999 gives a 404?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12004.}

[philip-sorokin]

Yes, it does.

[philip-sorokin]

The same behaviour you can see in the content_pagebreak plugin - if an article page does not exist, it gives a 404. Why not apply this approach to category blogs? When you have 200 pages, search engines index them, then you change the item per page number and 200 becomes 100. The problem is that the other 100 pages no longer exist, but they cannot be removed from search index without editing robots.txt/htaccess. I think it is very inconvenient.

[ghost]

I have tested this item 🔴 unsuccessfully on 504c948

With or -out patch pages open. Example: Show 1 of 2 Pages, append in URL ?start=99999999 – always 2 (the last page) is shown.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12004.}

[philip-sorokin]

@franz-wohlkoenig

I use the RC demo pages (featured view). I set in the menu params the following configuration to make pagination:

Leading Articles - 1
Intro Articles - 1
Columns - 1
Links - 1

When I open page 4 that does not have any items, I get the 404. Could you, please, describe your testing instructions?

[ghost]

@philip-sorokin Test Instructions shown in opened Comment.

[philip-sorokin]

@franz-wohlkoenig
Can you give me a link to this comment. I am sorry, can't find it.

[ghost]

on Top of this Thread, its your opening Comment about Issue.

[philip-sorokin]

Still can't see any comments.

[ghost]

what i mean is:

[philip-sorokin]

@franz-wohlkoenig
This is my testing instructions, I thought you would write yours. Please, give me more details on the failure, because I tested it in 3 views successfuly:

-archive
-category
-featured

[ghost]

I used your Instructions for Test. Have to retest, my Test is too long ago to remember.

[ghost]

Test on "Archive". 9 archived Articles (5 en-GB, 4 All Lang.), Menu set on Lang. "en-GB".

1/4. Call menu, Pagination show 1/2 (expected):

2/4. Click Pagnation 2/2, Url change to index.php/en/archived-articles?start=5 (expected):

3/4. Change Url to index.php/en/archived-articles?start=6 (unexpected – Articles with Lang.: All are shown):

4/4. Change Url to index.php/en/archived-articles?start=9 (expected – 404

[philip-sorokin]

And what is your conclusion? What about other views?

[wojsmol]

@philip-sorokin @franz-wohlkoenig don't expect this

3/4. Change Url to index.php/en/archived-articles?start=6 (unexpected – Articles with Lang.: All are shown):

[ghost]

@wojsmol didn't get what you mean.

[wojsmol]

@franz-wohlkoenig See #12004 (comment) first question

[ghost]

I have no Conclusion cause no Knowledge.

[philip-sorokin]

I am closing this PR as it is not going to be merged.