-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML Codestyle for the file application.xml #12080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are doing a full cs review of the xml you should folllow the name, type, labeldescription order as code style rules.
@@ -150,7 +162,8 @@ | |||
label="COM_CONFIG_FIELD_REDIS_PERSISTENT_LABEL" | |||
description="COM_CONFIG_FIELD_REDIS_PERSISTENT_DESC" | |||
filter="integer" | |||
showon="caching:1,2[AND]cache_handler:redis"> | |||
showon="caching:1,2[AND]cache_handler:redis" | |||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a tab here
I have tested this item ✅ successfully on c3673d2 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12080. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zero-24 @andrepereiradasilva Please see zero-24#17 |
Looks good just one smal comment in that PR. Thanks @wojsmol 👍 |
* XML CS fixes * Update application.xml fixed options order
description="COM_CONFIG_ACTION_EDITOWN_DESC" /> | ||
filter="rules" | ||
> | ||
<action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the action
idented with an extra tab? the option
are not...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 351db4e
Thanks @wojsmol |
I have tested this item ✅ successfully on 351db4e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12080. |
cc @JoomliC Please do a code review 😄 |
this is now moved to be against 3.7.x |
Summary of Changes
XML Codestyle for the file
administrator/components/com_config/model/form/application.xml
Testing Instructions
Documentation Changes Required
none