-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message area does not collapse when message is dismissed #12155
Comments
It is not an issue with the information message type. The problem is that when you have more than one message the "collapse" only happens on dismissing the first one |
Ah I see, this is unusual behaviour though right? We should try to "fix" it? The average user will see this as a mistake in my opinion so a UX fail. Or is this something that's unfixable? |
Yes it is a bug - i was just correcting your description of the issue |
I think it is an issue even when you have one notification. I was able to reproduce it with one error message. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155. |
@Achal-Aggarwal |
@infograf768 If I am mistaken then I guess we should fix that message as well. It is bad user experience if as a user I click on close and message does get closed but leave empty white space for nothing. Due to limited Ui knowledge I am not sure how to fix this, but give me few hours to see what's wrong there. |
i was speaking of the jed message, not the error message. it closes fine here |
Just FYI to those who didn't see the other issue regarding this. It's to do with the Javascript here: https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/js/template.js#L297 |
Looking into this, #jab17 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155. |
Hi @C-Lodder can you point us at which other issue is related to this exactly?? Thsnks This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155. |
The issue come from the code in the issue above. Been a while since I properly debugged this, but it's something to do with replacing |
Looks like this has been resolved elsewhere as it can no longer be reproducced |
Steps to reproduce the issue
Go to admin install something so you generate a message. When the message arrives dismiss it. The success message collapses. I think the error message collapses too. The information messages do not collapse.
Expected result
The success message collapses. I think the error message collapses too.
The information message collapses like the other two.
Actual result
The information messages do not collapse.
Here is a video of me doing this. https://dl.dropboxusercontent.com/u/40004789/joomla-admin.mp4
System information (as much as possible)
Additional comments
The text was updated successfully, but these errors were encountered: