Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message area does not collapse when message is dismissed #12155

Closed
uglyeoin opened this issue Sep 23, 2016 · 13 comments
Closed

Message area does not collapse when message is dismissed #12155

uglyeoin opened this issue Sep 23, 2016 · 13 comments

Comments

@uglyeoin
Copy link
Contributor

uglyeoin commented Sep 23, 2016

Steps to reproduce the issue

Go to admin install something so you generate a message. When the message arrives dismiss it. The success message collapses. I think the error message collapses too. The information messages do not collapse.

Expected result

The success message collapses. I think the error message collapses too.
The information message collapses like the other two.

Actual result

The information messages do not collapse.

Here is a video of me doing this. https://dl.dropboxusercontent.com/u/40004789/joomla-admin.mp4

System information (as much as possible)

Additional comments

@brianteeman
Copy link
Contributor

It is not an issue with the information message type. The problem is that when you have more than one message the "collapse" only happens on dismissing the first one

@uglyeoin
Copy link
Contributor Author

Ah I see, this is unusual behaviour though right? We should try to "fix" it? The average user will see this as a mistake in my opinion so a UX fail. Or is this something that's unfixable?

@brianteeman
Copy link
Contributor

Yes it is a bug - i was just correcting your description of the issue

@Achal-Aggarwal
Copy link
Contributor

I think it is an issue even when you have one notification. I was able to reproduce it with one error message.
https://drive.google.com/file/d/0B3rA3UKTXpVsc1hOQmJJTG95OUU/view


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155.

@infograf768
Copy link
Member

infograf768 commented Oct 20, 2016

@Achal-Aggarwal
That JED message is very specific. It is not displayed in the same <div>, i.e. system-message-container
There is no Close button for it.

@Achal-Aggarwal
Copy link
Contributor

@infograf768
I can see that the message is wrapped under system-message-container only and there is a close button to close it.
screen shot 2016-10-20 at 7 35 43 pm

If I am mistaken then I guess we should fix that message as well. It is bad user experience if as a user I click on close and message does get closed but leave empty white space for nothing.

Due to limited Ui knowledge I am not sure how to fix this, but give me few hours to see what's wrong there.

@Achal-Aggarwal
Copy link
Contributor

Achal-Aggarwal commented Oct 20, 2016

It is so weird. Below change solves the problem and I don't have any idea why.

screen shot 2016-10-20 at 11 59 35 pm

@infograf768
Copy link
Member

i was speaking of the jed message, not the error message. it closes fine here

@C-Lodder
Copy link
Member

Just FYI to those who didn't see the other issue regarding this. It's to do with the Javascript here: https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/js/template.js#L297

@weeblr
Copy link
Contributor

weeblr commented Jun 3, 2017

Looking into this, #jab17


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155.

@weeblr
Copy link
Contributor

weeblr commented Jun 3, 2017

Hi @C-Lodder

can you point us at which other issue is related to this exactly??

Thsnks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12155.

@C-Lodder
Copy link
Member

C-Lodder commented Jun 3, 2017

The issue come from the code in the issue above. Been a while since I properly debugged this, but it's something to do with replacing span10 with span12 (and vice versa). I fixed this by doing the markup properly, but cannot remember exactly. Enjoy :)

@brianteeman
Copy link
Contributor

Looks like this has been resolved elsewhere as it can no longer be reproducced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants