3.7 Improve Cache Controller

[csthomas]

Pull Request for Issue #12133 and other optimizations.

Summary of Changes

• Deprecate get and store methods in JCacheController, subclasses should have own methods.
• Deprecate start and end methods in JCacheControllerOutput - joomla does not use it
• Deprecate call method in JCacheControllerCallback
• Remove setLifeTime, setCaching from JCacheController because __call() method can call it directly on JCache instance.
• Replace operator == to === for locked and locklooped variables.
• Do not store if lock can not be locked:

if ($locktest->locked === false && $locktest->locklooped === true)

• Add get and store method to JCacheControllerOutput which is the same as deprecated method get and store in JCacheController.
• In subclasses of JCacheController I did optimization on get methods.
  • move unlock() method before unserialize(...)
  • Generally unlock cache as fast as we can
• Do not use ternary operator on variables with a lots of data, see http://fabien.potencier.org/the-php-ternary-operator-fast-or-not.html

Testing Instructions

Joomla should work as before.
Code review.

Documentation Changes Required

None.

[csthomas]

Can I ask you @mbabker for a review?

[mbabker]

Looks fine, one PHPCS issue.

[mbabker]

PHPCS issue.

[csthomas]

Thanks Michael.

Now I have to wait for 2 successful tests:)

[ghost]

@csthomas Enable Cache and test if J works as before?

[csthomas]

Yes, be sure that cache works before patch

[ghost]

I have tested this item ✅ successfully on 87f42d5

Tested on Articles, Blog, List, Contact, Feed, Search.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12312.}

[JoshJourney]

I have tested this item ✅ successfully on 87f42d5

Logged in, logged out, created article, viewed list, viewed article, changed site settings on frontend, ect. Seems to work great on every view I tested. Successfully tested this PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12312.}

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12312.}