Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix less / css #12548

Merged
merged 1 commit into from Nov 1, 2016
Merged

fix less / css #12548

merged 1 commit into from Nov 1, 2016

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 25, 2016

recompile less using our generatecss.php script

Most changes seem to be codestyle - i guess someone used a different less compiler

BUT check the changes to input-prepend

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Oct 25, 2016
@Bakual
Copy link
Contributor

Bakual commented Oct 25, 2016

The input-prepend stuff is related to this PR that was merged lately: #12442

@Bakual
Copy link
Contributor

Bakual commented Oct 25, 2016

Btw: https://github.com/joomla/joomla-cms/blob/3.7.x/media/jui/less/bootstrap-extended.less#L376-L383 doesn't look right (and is also related to the mentioned PR).

@zero-24
Copy link
Contributor

zero-24 commented Oct 25, 2016

@ciar4n can you take a look here?

@ciar4n
Copy link
Contributor

ciar4n commented Oct 25, 2016

I have tested this item ✅ successfully on 3e6bd2c

@brianteeman Apologies as this was most likely my doing. Noted for future PRs! :)

@Bakual I emptied these selectors for #12442 . As empty selectors are ignored by LESS, I didn't bother removing them.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.

@Bakual
Copy link
Contributor

Bakual commented Oct 25, 2016

As empty selectors are ignored by LESS, I didn't bother removing them.

You should have, as empty selectors are useless 😄

@ciar4n
Copy link
Contributor

ciar4n commented Oct 25, 2016

@Bakual True :) They are not outputted to the CSS so no ill effect for the time been. I'll remove them at the next given chance.

@rdeutz rdeutz changed the base branch from 3.7.x to staging October 25, 2016 16:06
@brianteeman
Copy link
Contributor Author

@zero-24 @Bakual can you guys test this so we can get it merged and then other PRs wont be effected by this error


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.

@Bakual
Copy link
Contributor

Bakual commented Oct 31, 2016

I have tested this item ✅ successfully on 3e6bd2c

Tested with Protostar, Isis and my own template and couldn't see any notable difference.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12548.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2016
@rdeutz rdeutz merged commit 79d6abf into joomla:staging Nov 1, 2016
@brianteeman
Copy link
Contributor Author

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2016
@brianteeman brianteeman deleted the fix_less_compile branch November 1, 2016 09:41
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants