Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct default values for user creation in the backend #12589

Merged
merged 4 commits into from Nov 1, 2016

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Oct 27, 2016

Summary of Changes

https://github.com/joomla/joomla-cms/blob/3.6.4/administrator/components/com_users/config.xml#L45-L68

Default values should be send mail to admin and admin activation.

That comes form here: cedd2d2 and got reverted between that. This implements it back.

Testing Instructions

install https://github.com/zero-24/joomla-cms/archive/install_SQL.zip
confirm the settings are equal to the XML

Documentation Changes Required

None.

@zero-24 zero-24 changed the title Set correct default values Set correct default values for user creation in the backend Oct 27, 2016
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Oct 27, 2016
@brianteeman
Copy link
Contributor

wow that was a really old patch of mine https://developer.joomla.org/joomlacode-archive/issue-31319.html

@zero-24
Copy link
Member Author

zero-24 commented Oct 27, 2016

Corrcet and anyhow this got reverted in the SQL files ;)

@zero-24
Copy link
Member Author

zero-24 commented Oct 31, 2016

As this prevents using wrong and insecure default configurations I hope we can get this tested?

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on ba0b2ae

on code review. the default in xml is 2 (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/config.xml#L48) so makes sense it's 2 also in sql


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12589.

@alikon
Copy link
Contributor

alikon commented Nov 1, 2016

I have tested this item ✅ successfully on ba0b2ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12589.

@zero-24
Copy link
Member Author

zero-24 commented Nov 1, 2016

Thanks RTC. 👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12589.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 1, 2016
@rdeutz rdeutz merged commit cb47e57 into joomla:staging Nov 1, 2016
@zero-24 zero-24 deleted the install_SQL branch November 1, 2016 14:14
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Nov 1, 2016
nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
…2589)

* Update joomla.sql

* Update joomla.sql

* Update joomla.sql
wilsonge pushed a commit that referenced this pull request Dec 15, 2016
* Update joomla.sql

* Update joomla.sql

* Update joomla.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants