Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules db table] Add default to content db field in mysql (already like that is postgresql and sqlsrv) #13035

Merged
merged 2 commits into from
Dec 6, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 26, 2016

Summary of Changes

Add empty default value to #__modules content db field in mysql (already like that is postgresql and sqlsrv).

Testing Instructions

Mainly code review. But you can also:

  • On update

    • Run the update query for your db system manually and check the db field now as a default value.
  • On install

    • Use latest staging, apply patch
    • Delete configuration.php file and install as usual. Check all fine and the db field are correctly created.

Documentation Changes Required

None.

Notes

Although the issue was found on 4.0 because of a more strict sql_mode, this also applies in 3.x since this db field should always have a default value.

@andrepereiradasilva andrepereiradasilva changed the title [modules db table] Add default to content db field in mysql (already like that is postgresql and sqksrv) [modules db table] Add default to content db field in mysql (already like that is postgresql and sqlsrv) Nov 26, 2016
@yvesh
Copy link
Member

yvesh commented Nov 26, 2016

I have tested this item ✅ successfully on 5e2d504

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.

@alikon
Copy link
Contributor

alikon commented Nov 26, 2016

I have tested this item ✅ successfully on 5e2d504


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.

1 similar comment
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 5e2d504


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13035.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2016
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Nov 26, 2016
@wilsonge
Copy link
Contributor

What is this field used for? If it's not used I'd rather remove it in postgres and mssql than keep junk

@brianteeman
Copy link
Contributor

@wilsonge it is the field that stores the content of any custom_html module

@rdeutz rdeutz merged commit ad1ff7c into joomla:staging Dec 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 6, 2016
@andrepereiradasilva andrepereiradasilva deleted the modules-default-content branch December 7, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants