Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install adapters return extension ID on success #13039

Merged
merged 1 commit into from Nov 27, 2016
Merged

Install adapters return extension ID on success #13039

merged 1 commit into from Nov 27, 2016

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Nov 27, 2016

Summary of Changes

JInstallerAdapter::install() and JInstallerAdapter::update() return the extension ID of the installed/updated extension on success, these methods do not only return boolean values. Fixed the docs.

Testing Instructions

Review

Documentation Changes Required

Already done 😉

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on ce9ce1e

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13039.

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on ce9ce1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13039.

@wilsonge wilsonge merged commit 9c30ade into joomla:staging Nov 27, 2016
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Nov 27, 2016
@mbabker mbabker deleted the installer-doc-bugs branch November 27, 2016 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants