Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual Managers: htmlspecialchars needed #13043

Merged
merged 1 commit into from Nov 29, 2016

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 28, 2016

Summary of Changes

Passing $item->title through htmlspecialchars()

Testing Instructions

Create a multilingual site (2 languages are enough).
Associate 2 articles.
Associate 2 categories.
Associate 2 menu items.
Associate 2 contacts.
Associate 2 newsfeeds.

For each of these add double quotes in the title of one of the items.
Example: mymenu "Useful", etc.

Display the managers for each kind of item
You will get stuff like this in the associations column (here the title is Poètes "français")

screen shot 2016-11-28 at 10 38 11
or for contact "en"

screen shot 2016-11-28 at 10 33 53

Patch, now you will correctly get:
screen shot 2016-11-28 at 10 56 06

and

screen shot 2016-11-28 at 10 35 50

same for the other components.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 671d36d

works as described. and solves the issue.
but i really think we should considere another PR shoulçd be done to transform this buttons in a unified layout.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13043.

@marcochirienti
Copy link
Contributor

I don't want to bother you, i just can't figure it out...
Why mixing JViewLegacy->escape() and htmlspecialchars()?
I've seen both being used throughout the CMS.
Is there a preference of one over the other inside html views?

@marcochirienti
Copy link
Contributor

Maybe this is not the right place for such a question. I know that it is not stricly related with the pull request. Anyway, where i should submit this kind of questions?

@Bakual
Copy link
Contributor

Bakual commented Nov 28, 2016

@marcochirienti https://groups.google.com/forum/#!forum/joomla-dev-general would be a proper place.
Since this here is about helpers and not views, JViewLegay->escape doesn't make sense anyway.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 671d36d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13043.

@dgrammatiko
Copy link
Contributor

RTC

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 28, 2016
@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 28, 2016
@marcochirienti
Copy link
Contributor

Ok, thank you @Bakual.

@wilsonge wilsonge merged commit f44f859 into joomla:staging Nov 29, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants