Multilingual Managers: htmlspecialchars needed #13043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Passing
$item->title
throughhtmlspecialchars()
Testing Instructions
Create a multilingual site (2 languages are enough).
Associate 2 articles.
Associate 2 categories.
Associate 2 menu items.
Associate 2 contacts.
Associate 2 newsfeeds.
For each of these add double quotes in the title of one of the items.
Example:
mymenu "Useful"
, etc.Display the managers for each kind of item
You will get stuff like this in the associations column (here the title is
Poètes "français"
)or for
contact "en"
Patch, now you will correctly get:
and
same for the other components.