Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com-fields]Clarify label #13068

Merged
merged 1 commit into from
Dec 5, 2016
Merged

[com-fields]Clarify label #13068

merged 1 commit into from
Dec 5, 2016

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Dec 3, 2016

It was highlighted in Pull Request for Issue #13051 that the field labeled class was not clear. This PR changes it to say edit class

9lhi

@ggppdk
Copy link
Contributor

ggppdk commented Dec 3, 2016

It is good, but what about "Render" class ?

please see the popup description: "The class attribute of the field when the field is rendered ..."
almost like sounds like: "The class attribute of the form field, when the form field is rendered ..."

besides, a form field is not "rendered" ? i think it is rendered too

So what about:
Class (viewing)
Class (editing)

@ggppdk
Copy link
Contributor

ggppdk commented Dec 4, 2016

I have tested this item ✅ successfully on d149b8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13068.

1 similar comment
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on d149b8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13068.

@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Dec 4, 2016
@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13068.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 4, 2016
@wilsonge wilsonge merged commit dcd8ccf into joomla:staging Dec 5, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 5, 2016
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the austria branch December 5, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants