Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized FinderIndexerHelper->stem() method #13480

Merged
merged 2 commits into from
Feb 5, 2017
Merged

Optimized FinderIndexerHelper->stem() method #13480

merged 2 commits into from
Feb 5, 2017

Conversation

frankmayer
Copy link
Contributor

@frankmayer frankmayer commented Jan 5, 2017

Summary of Changes

  • Optimized FinderIndexerHelper->stem() method now being five times faster on its own running time (under PHP 7.0, probably even faster under 5.6).
  • One type safe comparison

Testing Instructions

  • Code review
  • Though no change in behavior is expected, indexing and search-tests with English and non-English content should probably be done.

Documentation Changes Required

None

@frankmayer frankmayer mentioned this pull request Jan 8, 2017
4 tasks
@zero-24
Copy link
Contributor

zero-24 commented Feb 5, 2017

I have tested this item ✅ successfully on 3cb3583

Tested at #jc17de 😄


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13480.

@widmann-it
Copy link

I have tested this item ✅ successfully on 3cb3583

Successfully tested on #jc17de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13480.

@gunthelm2000
Copy link

I have tested this item ✅ successfully on 3cb3583


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13480.

@gunthelm2000
Copy link

Successfully tested on #jc17de


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13480.

@rdeutz rdeutz added this to the Joomla 3.7.0 milestone Feb 5, 2017
@rdeutz rdeutz merged commit aef1f24 into joomla:staging Feb 5, 2017
@frankmayer frankmayer deleted the indexer-performance-2 branch June 4, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants