New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup batch copy of items #13501
Cleanup batch copy of items #13501
Conversation
I have tested this item 🔴 unsuccessfully on 44f856d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501. |
44f856d
to
9782721
Compare
Hey both. can you please tell me what errors you are getting. I can't seem to reproduce anything at the moment (I have merged in staging since you both tested so it might be simply related to that) |
See the Screenshot, i've uploaded |
Hmm I definitely can't reproduce. Can you please try again on a clean copy of staging/nightly. Maybe just merging in staging now fixed something? |
Reproduced it on a nightly build - same error. It's localhost with xampp on windows10 php7.0.9 |
Feel free to contact @zero-24 |
@wilsonge it is about the different sql definition https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L111 for banners the |
Umm i don't understand how I can't reproduce this cause clearly you are correct. But I guess this latest version should fix things? |
I have tested this item ✅ successfully on 1121efe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501. |
Merged in staging |
@wilsonge Is this merged?? If not, can you update the merge conflicts? |
I have tested this item 🔴 unsuccessfully on 2952f2a
therefore tested unsuccessful This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501. |
f53e4e1
to
7ec4d5d
Compare
I have tested this item ✅ successfully on 7ec4d5d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501. |
Summary of Changes
Cleanup of the batch copy'ing of data. This introduces a empty post processing of batch copied data in order for com_content to add items into the frontpage table (and other components to do whatever processing they want).
Testing Instructions
Test Banners, Newsfeeds and contact work as is (there are no changes here - they just implement the parent method which is the same)
In com_content test batch copying with items that are featured and aren't featured and ensure that items are created correctly in the
#__content_frontpage
tableDocumentation Changes Required
None