Change email notification to use site from address (Fix #9261) #13518
Conversation
|
I have tested this item ✅ successfully on db2e207 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518. |
|
As pointed out in #16107 the site email address is not a required or a validated field This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518. |
|
Still a better option than potentially spoofing someone's email address as if it's configured properly that would be valid data from the site owner. |
|
i agree i was just pointing it out and that with this PR there is even more reason to merge #16107 |
|
Somewhat related: Our forms were setup to use the user's email for the FROM, and some got bounced/rejected:
Now FROM is the site's email and Reply-to is the user's email. |
|
Why add REPLY-TO? The email notification is generic. There is no context to the message to know what to reply to. |
|
@Quy you are probably correct but I guess someone could be overriding the message |
|
I have tested this item ✅ successfully on db2e207 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13518. |
|
RTC after two successful tests. |
joomla-cms-bot
added
Language Change
* staging: (1779 commits) Deprecate modules correction (joomla#16362) Removed unnecessary code in com_content (joomla#14628) Stop installation if minimum requirement isn't met. (joomla#15890) Deprecate parts of com_modules (joomla#16152) LICENSE.txt (joomla#16317) [a11y] [com_fields] icons in modals (joomla#15047) Load jQuery in associations edit layout (joomla#16240) HHVM was removed. Remove from travis conditionals (joomla#16281) Fix Stylesheet Mime type keeping b/c (joomla#16284) re-merge joomla#15068 and joomla#16256 Add showon attribute to add mailto link parameter (joomla#16282) Fix notices on Contact form (joomla#16279) Updating dutch TinyMCE files Media upload form margin (joomla#16253) Changes to display atom feeds correctly (joomla#16105) admin mod_latest (joomla#16277) Add truncate class and implement in popular articles module (joomla#16257) Using the "Special:MyLanguage" tag for links pointing to docs.joomla.org (joomla#15858) Change email notification to use site from address (Fix joomla#9261) (joomla#13518) Fix double encode ampersand in contact select list value (joomla#16268) ...
Pull Request for Issue #9261
Summary of Changes
The email notification sent when sending a private message uses the "from" user's email address as the sender which can cause some sending failures (see referenced issue for examples). This changes the process to set the "from" user as the reply-to address instead.
As well, proper error checks will be made when setting the reply-to and recipient addresses and the message will not be sent if this step fails. Additionally, a message will be displayed if sending
Concurrent with #13504 the log statements are wrapped in try/catch.
Testing Instructions
Pre-patch, an email message sent via the "Private Message" feature of com_messages will have the "from" address set as the sending user. Post-patch, the message will use the site's configured from address with the sending user set as the reply-to address.
Documentation Changes Required
N/A