Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Fixing ACL inheritance for fields and fieldgroups #13676

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jan 21, 2017

Pull Request for Issue #13662.

Summary of Changes

When we added context support for fieldgroups, the assetname wasn't taken care of properly and thus ACL inheritance broke.

Testing Instructions

  • Create some fieldgroups and assign some fields to it.
  • Play with ACL settings. Settings should inherit from the component to fieldsgroups to fields. That means for example if you allow or deny the "Edit Custom Field Value" action in a field group, the fields in it should take that permission.

Documentation Changes Required

None

@Bakual Bakual changed the title Fixing ACL inheritance for fields and fieldgroups [com_fields] Fixing ACL inheritance for fields and fieldgroups Jan 21, 2017
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on cf06d90

Tested permission inheritance from Component -> Field Group -> Field


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13676.

@ghost
Copy link

ghost commented Jan 22, 2017

I have tested this item ✅ successfully on cf06d90


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13676.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Jan 22, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jan 22, 2017
@wilsonge wilsonge merged commit 293d57e into joomla:staging Jan 22, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 22, 2017
@Bakual Bakual deleted the FixFieldGroupAssets branch January 22, 2017 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants