Limit Persistent Anonymous Data Collection Prompt To Control Panel #13948

zero-24 · 2017-02-06T09:49:40Z

Pull Request for Issue #13943 .

Summary of Changes

Testing Instructions

Install Joomla
Log In
Do not make a selection for Anonymous Data from the prompt
Navigate to some other pages

Expected result after the patch

The message is only showed in the control panel.

Actual result

Message is unnecessarily persistent all screens.
It's annoying and has a negative impact UX on all screens outside the control panel.

Documentation Changes Required

None

Additional comments ([copied from original issue by @cpfeifer])

I support the option to allow people to submit this data and it is very useful to our process, but there is no reason for it to be persistent across all screens unless our intent is to force users to make a decision, which it should never be.

This option is presented to our users as a way to help improve Joomla, but the persistent message essentially destroys UX everywhere outside the control panel by popping up and pushing all features down the screen considerably until they make choice. The choice they make may be out of frustration or a desire to make the message go away, and this potentially skews the data regarding the choices users are making.

If it's limited to being persistent on the dashboard, they'll see it when they login, which I still don't like but it's better than the way it is now. I think the presentation of this option should be completed revisited in J4, but I feel limiting it to the control panel is a fair compromise for now. I hope we can do something about this sooner than later.

User Feedback:
"Given that I have clients using the back end, if they see the messages it confuses them, and scares them."

wilsonge · 2017-02-06T09:59:40Z

-1 for me. We had a long discussion about this at the time of implementation. This was the solution rather than forcing users to accept. I'm strongly against going even further backwards on this

mbabker · 2017-02-06T13:26:16Z

I still don't get why the project feels like the stats collection notice should be in your face everywhere while the 2.5 EOL message and now our PHP EOL message get locked to the control panel only; those are more urgent things to be communicating to users.

ghost · 2017-02-06T15:18:55Z

We are throwing it in their face and forcing them to make a choice, that's the issue. Having this on the dashboard is one thing, having it on the article editing screen and every other screen is a whole other thing. It's too aggressive.

ghost · 2017-02-06T16:42:58Z

I have tested this item ✅ successfully on fc717c7

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13948.}

ghost · 2017-02-06T16:49:53Z

Here is a video of my test and I think it perfectly demonstrates the issue. I started with a fresh install and had to install and verify the patch tester without clicking the prompt. It's a huge distraction having the message pop up every single time on every single screen when you're trying to do something. Every time my mouse stalls out, that's my brain trying to process everything on the screen getting pushed down.

I can't believe for a second that any Joomla user is okay with this the way it is. Let's fix this now.

C-Lodder · 2017-02-06T17:07:33Z

plugins/system/stats/stats.php

@@ -94,6 +94,12 @@ public function onAfterInitialise()
 		// Load plugin language files only when needed (ex: they are not needed in site client).
 		$this->loadLanguage();


Code seems fine. But would it not be best to put it above $this->loadLanguage();? No need to load the language if it will potentially return

Agree, @zero-24 can you move it after the if statement.

That break the translation and result into a not translated message:

As the option is not set to com_cpanel on that screen. if i add it manually it works but not without.
administrator/index.php?option=com_cpanel

Ok, didn't think about that.

C-Lodder · 2017-02-06T17:09:48Z

Agree with Babker, so I'd personally suggest moving this to a post installation message (as that's pretty much what it is)

zero-24 · 2017-02-06T17:39:04Z

@C-Lodder i have tryed this and this resulted into a not translated message :(

I personally dont care. The reason it is not a postinstall is because we asuming that sending is allowed after a few time (i cant remember the actual time we wait) This is also the reason we need to force the user to take a chooice. ;)

Bakual · 2017-02-06T19:00:45Z

On the other hand, just press one of the buttons and it will never show up again.
I always do that directly after installation since it annoys me to much (which it does by design)

ghost · 2017-02-06T20:35:14Z

Put yourself in the shoes of a person who has never used Joomla before. You install for the first time, this message is the first you see when you login, then it follows you everywhere until you choose. What message are we sending to new users?

We need to think about that more. We're all used to this, but from an onboarding perspective it's a nightmare. This does not deliver a pleasant first user experience, and first impressions count for a lot. That's where my head is at.

ghost · 2017-02-07T07:09:55Z

Show on Control Panel is enough. After next Update the Message come again, User knows more about Reasons why its helping to click "Always send".

ghost · 2017-02-22T14:51:20Z

Decision of Production Department?

Sieger66 · 2017-03-03T10:14:03Z

I have tested this item ✅ successfully on fc717c7

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13948.}

zero-24 · 2017-03-04T10:08:26Z

Moving to Needs Review on request by @yvesh

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13948.}

mbabker · 2017-03-16T19:37:35Z

RTC

Please note per a discussion with Tobias that apparently moving the load language call after the cpanel check causes the messages to not translate. Let's move forward with this as is and we can address that issue separate.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13948.}

zero-24 · 2017-03-16T20:31:46Z

This PR is wrong.. As with this PR we just include the js in com_cpanel and if we do so there come no updates to the stats server (you need to be on the cpanel that the code is triggerd). I'm working on a fix.

zero-24 · 2017-03-16T21:14:55Z

I need some more input :(

The plugin is trigger twice.. the first time with com_cpanel as option and the seccond time with com_ajax.
This means if we add any check like above we add the js only on com_cpanel to the actual site, wich is wrong i think as this way the stats sending is not triggerd anywhere else than com_cpanel.

Or do we get the decision that it is ok that we are only sending the stats if we are on the cpanel?

zero-24 · 2017-03-16T21:15:57Z

If we have that decision i can also fix the languages part by moving that code to the onAjaxSendStats method.

zero-24 · 2017-03-16T21:19:41Z

In order to fix this: #14615 we can move that the code to onGetIcons event (wich is only triggerd in com_cpanel too)..

mbabker · 2017-03-16T21:20:06Z

IIRC the design was so that the collection could happen regardless of who is logged into the site or where (same way the update notification email plugin triggers independently of an admin logging into the site). So we shouldn't limit that part to someone logging into the site and hitting the control panel.

Use the plugin's isAjaxRequest method if you need to do something conditional based on full page request or AJAX.

zero-24 · 2017-03-16T21:23:55Z

IIRC the design was so that the collection could happen regardless of who is logged into the site or where (same way the update notification email plugin triggers independently of an admin logging into the site). So we shouldn't limit that part to someone logging into the site and hitting the control panel.

That is also broken by this line: https://github.com/joomla/joomla-cms/blob/staging/plugins/system/stats/stats.php#L79

mbabker · 2017-03-16T21:29:45Z

I give up. Ping me if the server side breaks 🤣

zero-24 · 2017-03-16T21:51:31Z

I give up. Ping me if the server side breaks

hehe 😄 Thanks anyway. Your reply means we need to find a fix for that.

yvesh · 2017-03-17T11:00:36Z

You have to add the original option from which com_ajax is called in the JavaScript :-) Than you can decide there if you render or not..

laoneo · 2017-06-12T06:57:45Z

Why did you close it?

zero-24 · 2017-06-12T11:32:46Z

It did never worked correctly. If you have a solution you can do a new PR :)

Update stats.php

0e91281

joomla-cms-bot added the PR-staging label Feb 6, 2017

zero-24 mentioned this pull request Feb 6, 2017

Limit Persistent Anonymous Data Collection Prompt To Control Panel #13943

Closed

Update stats.php

fc717c7

C-Lodder reviewed Feb 6, 2017

View reviewed changes

mbabker approved these changes Mar 16, 2017

View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2017

zero-24 removed the RTC This Pull Request is Ready To Commit label Mar 16, 2017

Merge branch 'staging' into zero-24-patch-2

079f5ee

zero-24 closed this Jun 11, 2017

zero-24 deleted the zero-24-patch-2 branch June 11, 2017 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit Persistent Anonymous Data Collection Prompt To Control Panel #13948

Limit Persistent Anonymous Data Collection Prompt To Control Panel #13948

zero-24 commented Feb 6, 2017 •

edited by joomla-cms-bot

wilsonge commented Feb 6, 2017

mbabker commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 6, 2017 •

edited by ghost

C-Lodder Feb 6, 2017

laoneo Mar 16, 2017

zero-24 Mar 16, 2017

laoneo Mar 16, 2017

C-Lodder commented Feb 6, 2017 •

edited

zero-24 commented Feb 6, 2017

Bakual commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 7, 2017

ghost commented Feb 22, 2017

Sieger66 commented Mar 3, 2017

zero-24 commented Mar 4, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

yvesh commented Mar 17, 2017

laoneo commented Jun 12, 2017

zero-24 commented Jun 12, 2017

		@@ -94,6 +94,12 @@ public function onAfterInitialise()
		// Load plugin language files only when needed (ex: they are not needed in site client).
		$this->loadLanguage();

Limit Persistent Anonymous Data Collection Prompt To Control Panel #13948

Limit Persistent Anonymous Data Collection Prompt To Control Panel #13948

Conversation

zero-24 commented Feb 6, 2017 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

Expected result after the patch

Actual result

Documentation Changes Required

Additional comments ([copied from original issue by @cpfeifer])

wilsonge commented Feb 6, 2017

mbabker commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 6, 2017 • edited by ghost

C-Lodder Feb 6, 2017

Choose a reason for hiding this comment

laoneo Mar 16, 2017

Choose a reason for hiding this comment

zero-24 Mar 16, 2017

Choose a reason for hiding this comment

laoneo Mar 16, 2017

Choose a reason for hiding this comment

C-Lodder commented Feb 6, 2017 • edited

zero-24 commented Feb 6, 2017

Bakual commented Feb 6, 2017

ghost commented Feb 6, 2017

ghost commented Feb 7, 2017

ghost commented Feb 22, 2017

Sieger66 commented Mar 3, 2017

zero-24 commented Mar 4, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

zero-24 commented Mar 16, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

mbabker commented Mar 16, 2017

zero-24 commented Mar 16, 2017

yvesh commented Mar 17, 2017

laoneo commented Jun 12, 2017

zero-24 commented Jun 12, 2017

zero-24 commented Feb 6, 2017 •

edited by joomla-cms-bot

ghost commented Feb 6, 2017 •

edited by ghost

C-Lodder commented Feb 6, 2017 •

edited