Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Isis] Post Install Messages #13992

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Feb 9, 2017

Pull Request for Issue # .

Summary of Changes

Adds some styling to the 'Post Installation Messages'.

Testing Instructions

Apply patch and navigate to Components -> Post Installation Messages

Before Patch

post-install1

After Patch

post-install2

Documentation Changes Required

None

@dgrammatiko
Copy link
Contributor

@ciar4n can you also apply a well class in the right hand side (the Release news section)?

@dgrammatiko
Copy link
Contributor

@ghost
Copy link

ghost commented Feb 9, 2017

I have tested this item ✅ successfully on e190835


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13992.

1 similar comment
@C-Lodder
Copy link
Member

C-Lodder commented Feb 9, 2017

I have tested this item ✅ successfully on e190835


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13992.

@ciar4n
Copy link
Contributor Author

ciar4n commented Feb 9, 2017

@dgt41 Here's with a BS well applied to the right column. Personally I don't think it needs it but happy to add it if you wish...

post-install3

@ghost
Copy link

ghost commented Feb 9, 2017

@dgt41 release notes without well looks fine.

@C-Lodder
Copy link
Member

C-Lodder commented Feb 9, 2017

hmm preferred it without to be honest. Seems very 1990's now

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on e190835


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13992.

@dgrammatiko
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13992.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 9, 2017
@wilsonge wilsonge merged commit 88f80b7 into joomla:staging Feb 10, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Feb 10, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Feb 10, 2017
@wilsonge
Copy link
Contributor

Looks better :) Thanks!

@ciar4n ciar4n deleted the post-install-msg branch February 10, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants