Move JLanguage* to namespace #14410
Merged
Move JLanguage* to namespace #14410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvesh
reviewed
Mar 7, 2017
| defined('JPATH_PLATFORM') or die; | ||
|
|
||
| /** | ||
| * Utitlity class for multilang | ||
| * | ||
| * @since 2.5.4 | ||
| */ | ||
| class JLanguageMultilang | ||
| class Multilanguage |
There was a problem hiding this comment.
any reason to not capitalize it now? MultiLanguage
There was a problem hiding this comment.
Depending on the source you use "multilanguage" isn't even a word...
There was a problem hiding this comment.
Somebody on twitter told me that it is correct like it is now. But he can't comment because of a ban.
There was a problem hiding this comment.
That was my source https://en.wiktionary.org/wiki/multilanguage
There was a problem hiding this comment.
I saw that one too. Honestly I'd say it's fine as is. MultiLanguage works too. But I didn't major in English (any variant in case someone wants to comment on en-US-isms), so don't take my word as the gospel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the classes JLanguageAssociations and JLanguageMultilang to namespace.
To ensure BC, it was tested with lanternfish to have a test with an existing extension. Lanternfish is overriding JLanguageMultilang on the site part of Joomla and that worked. So @wilsonge guess we have a working real world scenario.