Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double double quote (Modal "Select a category") #14412

Merged
merged 1 commit into from Mar 8, 2017
Merged

Remove double double quote (Modal "Select a category") #14412

merged 1 commit into from Mar 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2017

Summary of Changes

Removed a double double quote (") from hidden input

Testing Instructions

  • BE > go to Users > User Notes > Add User Note
  • Open HTML source code of page.
  • In Firefox see line 380 (line number not reliable. Why ever.):
<input type="hidden" id="jform_catid_id" class="required modal-value" data-required="1" name="jform[catid]"" data-text="Select a Category" value="" />
  • There are 2 double quotes after jform[catid]

  • Apply patch and check again or code review.

@ghost ghost changed the title Remove double double quote Remove double double quote (Modal "Select a category") Mar 7, 2017
@ghost
Copy link
Author

ghost commented Mar 7, 2017

I have tested this item ✅ successfully on 6758fd7

PR installed: On Line 412 double double quote is removed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14412.

@zero-24
Copy link
Contributor

zero-24 commented Mar 7, 2017

I have tested this item ✅ successfully on 6758fd7

👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14412.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Mar 7, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Mar 7, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2017
@ghost
Copy link
Author

ghost commented Mar 8, 2017

RTC as there are 2 successfully Tests?

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 8, 2017
@zero-24
Copy link
Contributor

zero-24 commented Mar 8, 2017

@franz-wohlkoenig i have set this to RTC after testing? Do i miss something?

@ghost
Copy link
Author

ghost commented Mar 8, 2017

bot has removed:
bildschirmfoto 2017-03-08 um 13 49 28

@wilsonge wilsonge merged commit 7966588 into joomla:staging Mar 8, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 8, 2017
jjaracz pushed a commit to jjaracz/joomla-cms that referenced this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants