Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for the new 'Components menu container' menu item type #14585

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Missing translation for the new 'Components menu container' menu item type #14585

merged 1 commit into from
Mar 14, 2017

Conversation

joeforjoomla
Copy link
Contributor

@joeforjoomla joeforjoomla commented Mar 13, 2017

Steps to reproduce the issue

Install an extension such as Virtuemart

Expected result

All values in 'Show or Hide Menu Items' are translated as the standard
Joomla admin menu

Actual result

Only item marked as COM_XXX in the XML manifest file are translated,
none of the XXX are translated
menu_container_translation

… type

Steps to reproduce the issue

Install an extension such as Virtuemart

Expected result

All values in 'Show or Hide Menu Items' are translated as the standard
Joomla admin menu

Actual result

Only item marked as COM_XXX in the XML manifest file are translated,
none of the XXX are translated
@infograf768
Copy link
Member

@izharaazmi
Can you look at this?

@infograf768
Copy link
Member

Looks like Virtuemart is not using a normal xml

<name>VIRTUEMART</name>
instead of
<name>COM_VIRTUEMART</name>
or
<name>com_virtuemart</name>

which would explain that issue.

@izharaazmi
Copy link
Contributor

I am looking at this now. However I believe that since the language key string comes from the component manifest itself, the translation should still work if written in the extension.

@zero-24
Copy link
Contributor

zero-24 commented Mar 14, 2017

Looks like Virtuemart is not using a normal xml

The name don't need to be a translation string it can also be just text. So I think the element is the better choice here 😄

@infograf768
Copy link
Member

Tested patch and, yes, this PR makes sense and will work in any case.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 0d978ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14585.

@izharaazmi
Copy link
Contributor

Yeah right. I'd too choose element against name. Not sure why I did that in the first place.
Patch is good to me. 👍

@infograf768
Copy link
Member

RTC. Good find!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14585.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2017
@wilsonge wilsonge merged commit 79aa9d8 into joomla:staging Mar 14, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants