Stats-plugin debug mode #14634
Closed
Stats-plugin debug mode #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed joomla#14614 this PR comments out the debug mode ###Test Instructions Before PR you have a tab called Advanced in the System-Joomla statistics plugin After PR you dont have the tab
|
I think we should remove that instead of just comment the code out. |
|
If we need a debug option lets implement a constant you can change in the plugin code if you need to debug. |
|
PR welcome ;)
Personally I would have just deleted it completely
<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.
www.avg.com
<http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On 15 March 2017 at 10:59, zero-24 ***@***.***> wrote:
If we need a debug option lets implement a constant you can change in the
plugin code if you need to debug.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14634 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPH8RzU_RHvxbhmkvC5NBfukkIcxSbaks5rl8SFgaJpZM4Mdxc->
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ <http://brian.teeman.net/>
|
|
closed in favour of #15178 |
|
Sorry that it took that long :( see here: #15178 @brianteeman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #14614 this PR comments out the debug mode
###Test Instructions
Before PR you have a tab called Advanced in the System-Joomla statistics plugin
After PR you dont have the tab