Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_associations] Creating missing filters #14646

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Mar 15, 2017

This PR allows filtering items (articles, contacts, newsfeeds) per category.
It also allows to filter categories (for articles, contacts, newsfeeds) per level.
It also allows filtering menu items per level

Testing instructions

Create a multingual site with associations. 2 languages are enough.

Create articles, contacts, newsfeeds tagged to one language (it's enough for the test but one can test with both languages.)
Create categories and sub-categories for each component above tagged to one language (it's enough for the test but one can test with both languages.)
Create menu items and sub-menu items tagged to one language (it's enough for the test but one can test with both languages.)

Display Associations list:
/administrator/index.php?option=com_associations&view=associations

Before patch, there is no filtering of the items above by category.
Before patch there is no filtering by level for categories or menu items.

After patch these are now available.
Test everything is fine.

For categories

screen shot 2017-03-15 at 18 51 57

For Menu items

screen shot 2017-03-15 at 18 53 21

For items

screen shot 2017-03-15 at 18 54 20

Note: this PR does not solve yet the sorting by category.

@rdeutz

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1763507


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14646.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Mar 16, 2017

I have tested this item ✅ successfully on 1763507


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14646.

@ghost
Copy link

ghost commented Mar 16, 2017

RTC as there are 2 successfully Tests?

@infograf768
Copy link
Member Author

RTC. Thanks for testing!

@rdeutz will be confirming on Friday


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14646.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2017
@rdeutz rdeutz added this to the Joomla 3.7.0 milestone Mar 16, 2017
@rdeutz rdeutz merged commit 41ce34d into joomla:staging Mar 16, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 16, 2017
infograf768 added a commit to infograf768/weblinks that referenced this pull request Mar 16, 2017
This correction is similar to what was merged in core:
See joomla/joomla-cms#14646
zero-24 pushed a commit to joomla-extensions/weblinks that referenced this pull request Mar 16, 2017
This correction is similar to what was merged in core:
See joomla/joomla-cms#14646
Bakual pushed a commit that referenced this pull request Mar 16, 2017
@infograf768 infograf768 deleted the assoc_list_filters branch March 20, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants