[4.0] Fix validation tests failing #14922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
changed the title
dgrammatiko
commented
Mar 27, 2017
| beforeAll(function () { | ||
| Joomla.JText.load(ob); |
There was a problem hiding this comment.
Explaining the code here: the new validation requires the strings above so in order tests not to throw ugly errors we load them manually (in the test env these are not automatically loaded).
|
@wilsonge merge? |
dgrammatiko
deleted the
+++++++++++++++++++++++++++++++++++tests_4.0-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fix javascript tests
Testing Instructions
If drone is green we're golden
Expected result
Actual result
Documentation Changes Required