Languages: Changing error order when reinstalling a language #15022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
approved these changes
Mar 31, 2017
timwattenberg
approved these changes
Mar 31, 2017
|
Please, instead of "Approved" can you mark the Test as successful on issues.joomla.org ? |
|
I have tested this item ✅ successfully on f1b826a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022. |
|
I have tested this item successfully. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022. |
|
Tested this change successfully and also commented on Issue Tracker #15022 |
|
RTC. Thanks for Testing! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This changes the order of the errors when installing a language and creating a Content Language.
In 3.7.0/staging, a Content Language is automatically created (unpublished) when installing a language.
When uninstalling this language, the Content Language remains (which is correct behavior).
When the same language is installed again, the code checks for uniqueness of
sef
image (flag) used
Language Tag
The order is not important when editing Content Languages, but it is when reinstalling a language.
This PR reorders the errors
After patch when reinstalling a language for which the Content Language already exists, one will get:
Instead of:
Unable to create a content language for Persian language: A content language already exists with this Image.Thanks @imanickam for finding this issue.
Testers welcome.