TinyMCE drag and drop bug fixes #15057

dgrammatiko · 2017-04-02T15:13:56Z

Pull Request for Issue ##14906 .

Summary of Changes

Apart from fixing the bug in #14906 this PR also fixes another bug with the toolbar tooltip rendered in wrong position after the first image upload.
Also moves the plugin javascript code out of the tinyMCE/plugins directory (will make updates easier)

Testing Instructions

Edit the configuration and provide a custom path for the drag and drop upload, this setting is per tab option so make sure that you are using the right one!!!
Try to upload an image,
Check where the image is stored and also try to see if the tooltips in bold, italics etc is in the right position

Apply the patch and repeat

Expected result

Use the provided path

Actual result

Is not using the provided path

Documentation Changes Required

None, bug fix

AlexRed · 2017-04-02T16:16:21Z

ok, the patch fix the bug with the editor toolbar tooltip rendered in wrong position after the first image upload.
But for me the "Images Directory" parameter tooltip need to explain you can use the "Images Directory" parameter in the TinyMCE plugin to insert a folder name (not a path). This will be automatically generated by the system on the first dragging of an image. The folder will be created as a subfolder of the one set in the media manager settings as “Path to Files Folder”. Since they are image files, I think it would be better to set that it is created as a subfolder of the one set in the media manager settings as “Path to Images Folder”.

@brianteeman

make @brianteeman happy :)

dgrammatiko · 2017-04-02T16:59:38Z

The last commit transforms the inout to a drop down of possible directories, as @brianteeman suggested in the issue.
Personally I always prefer clicking instead of typing (although as a dev it should be the other way around :) )

For the tooltip text please make another PR

yvesh · 2017-04-02T17:05:18Z

plugins/editors/tinymce/field/uploaddirs.php

+		$options = array();
+		$root    = JComponentHelper::getParams('com_media')->get('image_path');
+
+


empty line :-)

yvesh · 2017-04-02T17:06:10Z

plugins/editors/tinymce/field/uploaddirs.php

+ */
+class JFormFieldUploaddirs extends JFormFieldList
+{
+	protected $type = 'uploaddirs';


do comment missing

yvesh · 2017-04-02T17:11:28Z

plugins/editors/tinymce/tinymce.php

+			$scriptOptions['uploadUri']       = $uploadUrl;
+
+			$externalPlugins = array(
+				array('jdragdrop' => ($app->isClient('site') ? JUri::root(false)  : str_replace('/administrator', JUri::root(false)))


JUri::root() should never contain administrator? :-)

Juri::root() in example.com/administrator returns example.com

yvesh · 2017-04-02T17:11:57Z

plugins/editors/tinymce/tinymce.php

@@ -573,7 +573,9 @@ public function onDisplay($name, $content, $width, $height, $col, $row, $buttons

 		if ($dragdrop && $user->authorise('core.create', 'com_media'))
 		{
-			$plugins[]     = 'jdragdrop';
+			$externalPlugins['jdragdrop'] = ($app->isClient('site') ? JUri::root(false)  :
+					str_replace('/administrator', '', JUri::root(false)))


JUri::root() should never contain administrator? :-)

Juri::root() in example.com/administrator returns example.com

AlexRed · 2017-04-02T17:30:51Z

I have tested this item 🔴 unsuccessfully on 330dcc0

no work for me.
I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

AlexRed · 2017-04-02T17:33:27Z

Sorry but I can't make a PR for the en language file.. my english is very bad :(

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

zero-24 · 2017-04-02T17:36:31Z

Please add a doc block for the new method to fix drone ;)

dgrammatiko · 2017-04-02T17:48:05Z

@AlexRed thanks, that should be ok now

AlexRed · 2017-04-02T17:55:21Z

no more dropdown ?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

dgrammatiko · 2017-04-02T17:57:03Z

It's still there for me:

AlexRed · 2017-04-02T18:08:08Z

sorry, dropdown ok but the image continue to go in a subfolder of Path to Files Folder in the Media: Options.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

dgrammatiko · 2017-04-02T18:11:13Z

@AlexRed are you on M$ win-dos machine?

AlexRed · 2017-04-02T18:18:17Z

No, linux

dgrammatiko · 2017-04-02T18:24:45Z

@AlexRed so can you post your settings, in tinymce and com_media, I can't really understand why your setup is misbehaving

dgrammatiko · 2017-04-02T18:33:25Z

I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/

OK, I've figured why you don't get the expected results.
The tinymce drag and drop folder is a subfolder of the folder that is set in com_media as Images folder.
The system actually behaves correctly, so it uses the "headers" from the tinyMCE options, but the base folder (before that) is from the the com_media. The last part cannot change in 3.x as it will be B/C break so you have to adjust the options in com_media that both folders point in the same directory, something like:

AlexRed · 2017-04-02T18:36:19Z

yes, I can. But the Joomla users when select the folder in the dropdown think the images go there... but no. The images go in a new subfolder with the same name if the user use the Path to Files Folder in the Media

dgrammatiko · 2017-04-02T18:38:44Z

But the Joomla users when select the folder in the dropdown think the images go there...

This folder that they will select is always a subfolder of their images directory, maybe a better tooltip there could be more helpful

AlexRed · 2017-04-02T18:41:42Z

yes, also for me the tooltip text need to explain better

brianteeman · 2017-04-02T18:47:23Z

use the esisting PLG_FIELDS_MEDIA_PARAMS_DIRECTORY_DESC

dgrammatiko · 2017-04-02T18:52:03Z

@brianteeman done

brianteeman · 2017-04-04T08:46:33Z

I have not tested this item.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

dgrammatiko · 2017-04-04T15:04:34Z

@brianteeman was that what you wanted to select in the issue tracker?

brianteeman · 2017-04-04T15:05:17Z

oops no

brianteeman · 2017-04-04T15:05:40Z

I have tested this item ✅ successfully on 9e6415a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

AlexRed · 2017-04-04T15:14:48Z

I have tested this item ✅ successfully on 9e6415a

Patch ok for me

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.}

ghost · 2017-04-04T15:29:11Z

RTC after two successful testes.

fixes

0f12c52

joomla-cms-bot added the PR-staging label Apr 2, 2017

dgrammatiko mentioned this pull request Apr 2, 2017

[tinymce] drag and drop images folder #14906

Closed

make the directory a dropdown list

48acb76

make @brianteeman happy :)

yvesh reviewed Apr 2, 2017

View reviewed changes

oops

330dcc0

dgrammatiko added 2 commits April 2, 2017 20:39

CS

06dd566

respect the images root folder

af9b542

respect the default value

eb79dbf

tooltip

7b86433

joomla-cms-bot added the Language Change This is for Translators label Apr 2, 2017

DRY

9e6415a

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2017

rdeutz added this to the Joomla 3.7.0 milestone Apr 4, 2017

rdeutz merged commit a6855d5 into joomla:staging Apr 4, 2017

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 4, 2017

schnuti mentioned this pull request Apr 30, 2017

Problems with tinyMCE width and height, joomla 3.7 #15059

Closed

dgrammatiko deleted the ++++++++++++++++++++++++++++++++++tinydnd branch July 22, 2017 20:11

HLeithner mentioned this pull request May 29, 2019

upload bug at joomla 3.9.6 #25015

Closed

dgrammatiko mentioned this pull request May 31, 2019

Tinymce doesn't need to remove the images basepath #25037

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TinyMCE drag and drop bug fixes #15057

TinyMCE drag and drop bug fixes #15057

dgrammatiko commented Apr 2, 2017 •

edited by joomla-cms-bot

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

yvesh Apr 2, 2017

yvesh Apr 2, 2017

yvesh Apr 2, 2017

yvesh Apr 2, 2017

AlexRed commented Apr 2, 2017

AlexRed commented Apr 2, 2017 •

edited

zero-24 commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

brianteeman commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

brianteeman commented Apr 4, 2017

dgrammatiko commented Apr 4, 2017

brianteeman commented Apr 4, 2017

brianteeman commented Apr 4, 2017

AlexRed commented Apr 4, 2017

ghost commented Apr 4, 2017

		$options = array();
		$root = JComponentHelper::getParams('com_media')->get('image_path');

TinyMCE drag and drop bug fixes #15057

TinyMCE drag and drop bug fixes #15057

Conversation

dgrammatiko commented Apr 2, 2017 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

yvesh Apr 2, 2017

Choose a reason for hiding this comment

yvesh Apr 2, 2017

Choose a reason for hiding this comment

yvesh Apr 2, 2017

Choose a reason for hiding this comment

yvesh Apr 2, 2017

Choose a reason for hiding this comment

AlexRed commented Apr 2, 2017

AlexRed commented Apr 2, 2017 • edited

zero-24 commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

AlexRed commented Apr 2, 2017

brianteeman commented Apr 2, 2017

dgrammatiko commented Apr 2, 2017

brianteeman commented Apr 4, 2017

dgrammatiko commented Apr 4, 2017

brianteeman commented Apr 4, 2017

brianteeman commented Apr 4, 2017

AlexRed commented Apr 4, 2017

ghost commented Apr 4, 2017

dgrammatiko commented Apr 2, 2017 •

edited by joomla-cms-bot

AlexRed commented Apr 2, 2017 •

edited