[a11y] com_ templates #15061
[a11y] com_ templates #15061
Conversation
| @@ -78,11 +78,11 @@ | |||
| <td> | |||
| <?php if ($this->preview && $item->client_id == '0') : ?> | |||
| <a target="_blank" href="<?php echo JUri::root() . 'index.php?tp=1&templateStyle=' . (int) $item->id ?>" class="jgrid"> | |||
| <span class="icon-eye-open hasTooltip" title="<?php echo JHtml::_('tooltipText', JText::_('COM_TEMPLATES_TEMPLATE_PREVIEW'), $item->title, 0); ?>" ></span></a> | |||
| <span class="icon-eye-open hasTooltip" aria-hidden="true" title="<?php echo JHtml::_('tooltipText', JText::_('COM_TEMPLATES_TEMPLATE_PREVIEW'), $item->title, 0); ?>" ></span></a> | |||
There was a problem hiding this comment.
Remove space before ></span>. Repeat for the other 2 changes.
| @@ -78,11 +78,11 @@ | |||
| <td> | |||
| <?php if ($this->preview && $item->client_id == '0') : ?> | |||
| <a target="_blank" href="<?php echo JUri::root() . 'index.php?tp=1&templateStyle=' . (int) $item->id ?>" class="jgrid"> | |||
| <span class="icon-eye-open hasTooltip" title="<?php echo JHtml::_('tooltipText', JText::_('COM_TEMPLATES_TEMPLATE_PREVIEW'), $item->title, 0); ?>" ></span></a> | |||
| <span class="icon-eye-open hasTooltip" aria-hidden="true" title="<?php echo JHtml::_('tooltipText', JText::_('COM_TEMPLATES_TEMPLATE_PREVIEW'), $item->title, 0); ?>"></span></a> | |||
There was a problem hiding this comment.
Given this one is a link do we want to provide something for the screenreader as alt text?
There was a problem hiding this comment.
I thought about it but then decided against it when I thought about what the link does - but I was wrong as I thought the link opened the preview image and not the entire site with the module positions. I will update it now. Good spot
|
I have tested this item ✅ successfully on 9cb2030 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15061. |
|
How to test this PR? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15061. |
|
I have tested this item ✅ successfully on 9cb2030 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15061. |
|
RTC after two successful tests. |
|
@brianteeman please check the conflicts, thanks |
|
conflicts resolved |
|
Thanks |
Continuing the work to prevent assistive technology reading out the value of an icon. This PR addresses the icons in com_templates as show in the screenshots below.