Remove .jform-rightbtn class #15097
Remove .jform-rightbtn class #15097
Conversation
|
I have tested this item ✅ successfully on effa15c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097. |
|
Do NOT take off the class from Do not modify components/com_finder/helpers/html/filter.php and leave it alone. These are used both by Isis AND Hathor!. OK for the change in administrator/components/com_templates/views/style/tmpl/edit_assignment.php as this one is overriden by Hathor |
| @@ -70,7 +70,7 @@ | |||
| <div class="well"> | |||
| <?php echo $this->form->renderField('map_count'); ?> | |||
| </div> | |||
| <button class="btn btn-default" type="button" class="jform-rightbtn" onclick="jQuery('.filter-node').each(function () { this.click(); });"> | |||
| <button class="btn btn-default" type="button" onclick="jQuery('.filter-node').each(function () { this.click(); });"> | |||
There was a problem hiding this comment.
btn-default isn't a BS2 class. Not needed
There was a problem hiding this comment.
and we use it 8 times :(
|
Seeing as this is used for Hathor, which already has it's own float classes, |
|
I suggest to wait for a decision concerning Hathor. See https://issues.joomla.org/tracker/joomla-cms/15079 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097. |
|
@infograf768 Decision is made (comment by @wilsonge): "There has been a decision made. Hathor will continue to ship with J3.x however we do not guarantee feature parity of all Joomla features (i.e. everything that works now should continue to work but we don't guarantee new features like fields and associations etc will continue to work fully - although we won't obviously reject any PR's if they come in)" This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097. |
|
@franz-wohlkoenig |
|
@infograf768 so this PR should be closed? |
|
it alreadt has conflicts, so i think it should be updated, and include the hathor changes. these are not new features, but css matters. |
|
I will open a new pr. |
Summary of Changes
From #15092, per @C-Lodder, this class is not needed.
Testing Instructions
Code review.