Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql install] Set all front menu modules to display sub menus per default when installing Joomla #15099

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Apr 5, 2017

Pull Request for Issue #15094

Summary of Changes

As title says.
When creating a frontend menu module the default is to show the sub menus.

				<field
					name="showAllChildren"
					type="radio"
					label="MOD_MENU_FIELD_ALLCHILDREN_LABEL"
					description="MOD_MENU_FIELD_ALLCHILDREN_DESC"
					class="btn-group btn-group-yesno"
					default="1"
					>
					<option value="1">JYES</option>
					<option value="0">JNO</option>
				</field>

This normalises this setting in all sample data.
I see no unwanted consequences: when no submenus available, no change.

Testing Instructions

Patch an instance of Joomla and install with various sample data
This can also be tested using this pack
https://github.com/infograf768/joomla-cms/archive/sub_menus_modules.zip

@ghost
Copy link

ghost commented Apr 5, 2017

@infograf768 installed your zip but don't get how to test.

@ghost
Copy link

ghost commented Apr 5, 2017

see its an complete install. Test now.

@infograf768
Copy link
Member Author

infograf768 commented Apr 5, 2017

It's indeed mostly code review, but you can check if none or any sample data installs ok, and then look at the menu modules to confirm that Sub Menu Items parameter is set to Yes.

@ghost
Copy link

ghost commented Apr 5, 2017

tested successfully (didn't get Button on Issue Tracker to mark)

@infograf768
Copy link
Member Author

We need one more tester.

@Quy
Copy link
Contributor

Quy commented Apr 5, 2017

Tested successfully via code review.

Should this file be updated too?
\joomla-cms\tests\unit\stubs\database\jos_modules.csv


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15099.

@ghost
Copy link

ghost commented Apr 5, 2017

RTC after two successful testes.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2017
@joomla-cms-bot joomla-cms-bot added this to the Joomla 3.7.0 milestone Apr 6, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 6, 2017
@rdeutz rdeutz merged commit 890ee73 into joomla:staging Apr 6, 2017
@rdeutz rdeutz self-assigned this Apr 6, 2017
@infograf768 infograf768 deleted the sub_menus_modules branch April 6, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants