Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] com_content columns - BS4 migration #15291

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Apr 13, 2017

Pull Request for Issue # .

Summary of Changes

Migrates intro article columns to BS4

Testing Instructions

Apply patch and open 'featured' or 'category blog' article list. Try various number of columns in menu item settings (Layout tab).

Before

col1

After

col2

Documentation Changes Required

@ghost
Copy link

ghost commented Apr 13, 2017

I have tested this item ✅ successfully on 524da96


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15291.

@rjcf18
Copy link
Contributor

rjcf18 commented Apr 14, 2017

I have tested this item ✅ successfully on 524da96 as you can see in the following images:

Before patch:
screen shot 2017-04-14 at 11 45 37

After patch:
screen shot 2017-04-14 at 11 46 08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15291.

@rjcf18
Copy link
Contributor

rjcf18 commented Apr 14, 2017

I have tested this item ✅ successfully on 524da96


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15291.

@ghost
Copy link

ghost commented Apr 14, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 14, 2017
@zero-24 zero-24 added this to the Joomla 4.0 milestone Apr 14, 2017
@mbabker mbabker added this to Testing/Review in [4.0] Aurora - Frontend Template Apr 14, 2017
@wilsonge wilsonge merged commit 0880824 into joomla:4.0-dev Apr 16, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 16, 2017
@ciar4n ciar4n deleted the bs4-columns branch April 16, 2017 15:15
@mbabker mbabker moved this from Testing/Review to Completed in [4.0] Aurora - Frontend Template Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants