Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong data type declaration #15309

Merged
merged 1 commit into from
Apr 16, 2017
Merged

Conversation

demis-palma
Copy link
Contributor

$current_update is declared as JUpdate, but actually it's a JTableUpdate instead.
If it was a JUpdate, the subsequent calls to properties $current_update->extra_query and $current_update->version would cause a fatal error, since they are protected properties.

It can be verified with the help of a the debugger.

@mbabker
Copy link
Contributor

mbabker commented Apr 14, 2017

Yes that is correct. update_sites is an array of associative arrays and updates is an array of JTableUpdate instances.

@wilsonge wilsonge merged commit 5176b81 into joomla:staging Apr 16, 2017
@wilsonge wilsonge added this to the Joomla 3.7.0 milestone Apr 16, 2017
@wilsonge
Copy link
Contributor

Dunno if someone wants to amend the class properties in those two classes to be JTableUpdate[]

rdeutz pushed a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017
@demis-palma demis-palma deleted the updater-1 branch May 4, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants