Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if com_fields is installed #15465

Merged
merged 2 commits into from Apr 23, 2017

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Apr 21, 2017

Pull Request for Issue #15401 .

Summary of Changes

Simple fix to prevent the message Warning Error loading component: com_fields, Component not found. from showing.
It doesn't necessary fix the potential underlying issue that com_fields isn't installed

Testing Instructions

If you got that message after updating, apply this PR and the message is gone

Documentation Changes Required

None

@mbabker
Copy link
Contributor

mbabker commented Apr 21, 2017

Can you do this so JComponentHelper::isInstalled('com_fields') is only called once? JComponentHelper::isInstalled() doesn't cache results so this in effect is adding two duplicate database queries to every admin page load right now, putting it in a variable at least brings it down to one non-duplicate (at least generated by this source).

@zero-24
Copy link
Contributor

zero-24 commented Apr 21, 2017

In oder to fix the drone error and the comment by michael what about using: $fields = JComponentHelper::isInstalled('com_fields') && JComponentHelper::isEnabled('com_fields');

And later: if ($fields && JComponentHelper::getParams('com_users')->get('custom_fields_enable', '1')) or if ($fields && JComponentHelper::getParams('com_content')->get('custom_fields_enable', '1'))

@Bakual
Copy link
Contributor Author

Bakual commented Apr 22, 2017

Done. I've chosen a different variable name so it's more clear.

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

👍 Can you get that in 3.7.0 @rdeutz ?

@rdeutz
Copy link
Contributor

rdeutz commented Apr 22, 2017

@zero-24 did you test if it works?

@rjcf18
Copy link
Contributor

rjcf18 commented Apr 22, 2017

I have tested this item ✅ successfully on f61d85b

Seems to have fixed the message that appears after updating.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

I have tested this item ✅ successfully on f61d85b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 22, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Apr 22, 2017
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.7.0 milestone Apr 22, 2017
@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

@zero-24
Copy link
Contributor

zero-24 commented Apr 22, 2017

yes @rdeutz


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

@rdeutz rdeutz added this to the Joomla 3.7.0 milestone Apr 23, 2017
@rdeutz rdeutz merged commit e4363ef into joomla:staging Apr 23, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2017
@Bakual Bakual deleted the FixErrorComFieldsNotFound branch April 23, 2017 19:15
@mcintyro
Copy link

I did the production upgrade to 3.7.0 from 3.6.5 and I have this warning on my admin console. The update was delivered using the Joomla Updater - I am not a developer so not sure if this issue was expected in 3.7.0 production or how to resolve it.

rdeutz pushed a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017
* Check if com_fields is installed

* Only run checks once
@l-arnold
Copy link

Ditto to Mcintyro above "production upgrade to 3.7.0 from 3.6.5"

Coupled with this I suspect FlexiContent is also problmatic with new com_fields behavior Basically I cannot find any "com_fields" but Joomla keeps giving the error:

Warning
Error loading component: com_fields, Component not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants