Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Tabs #15601

Closed
yarntoad opened this issue Apr 26, 2017 · 5 comments
Closed

Module Tabs #15601

yarntoad opened this issue Apr 26, 2017 · 5 comments

Comments

@yarntoad
Copy link

yarntoad commented Apr 26, 2017

Steps to reproduce the issue

This issue deals with module workflow. When you open a module and save/close, which ever tab you saved the module on is the tab presented when you open the next module and it has caused a few issues for our site. The issue I have found is that when you open an existing module and apply that module to a menu item and then save/close the module while still on the "Menu Assignment" tab, when you open another module the module tab goes right to where you last saved, in this case the "Menu Assignment" tab. This seemed handy at first but then I realized I was loosing all of my custom code in my custom modules because the module was opening right to the Menu Assignment tab and the first tab was toggled from Code Only to the WYSIWYG mode. Causing of course, the loss of my custom html code.

Expected result

I would expect to always open a custom module, or any module for that matter, directly to the first tab, the "Module" tab. Showing if the Module was toggled on Code or on the WYSIWYG.

Actual result

When you open a module, the module opens to which ever tab you had up when you clicked save last. So if the module is toggled to the WYSIWYG you do not see it and you save, loosing your custom code.

System information (as much as possible)

Running Joomla 3.7 and have seen same behavior in Chrome and Firefox.

Additional comments

@dgrammatiko
Copy link
Contributor

How about changing your workflow and always clicking the tab with the content before clicking save?
This feature is not new to Joomla, but since 3.7 is working as intended

@Bakual
Copy link
Contributor

Bakual commented Apr 26, 2017

The only thing that has changed with 3.7.0 is that now the "stored" tab isn't persistent anymore. If you close the browser, it will reset.
The idea of the code is that when you press "Save" (not "Save & Close") you stay on the active tab and don't jump back to the first.
Imho, it may be improved to store the state per item (eg take into account the item ID) and not globally for all items of the same view.

@yarntoad
Copy link
Author

Thanks for the details and we'll change our workflow accordingly. Thanks for all your hard work!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15601.

@ghost
Copy link

ghost commented Apr 27, 2017

@yarntoad if this Issue is resolved, please close it. Thanks.

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants