Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track plugins being loaded to unique dispatchers #15607

Merged
merged 6 commits into from
Jul 5, 2017
Merged

Track plugins being loaded to unique dispatchers #15607

merged 6 commits into from
Jul 5, 2017

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Apr 27, 2017

Pull Request for Issue #12690

Summary of Changes

JPluginHelper::importPlugin() has a static tracking array that only allows a plugin to be loaded once, preventing the ability for plugins to be registered to anything but the first dispatcher that gets used. Change the method to track loaded plugins based on the dispatcher to allow custom imports.

Testing Instructions

See the issue for more information.

Expected result

Plugins imported to each unique dispatcher.

Actual result

Plugins are only loaded to the first dispatcher (generally the singleton from JEventDispatcher::getInstance()).

Documentation Changes Required

N/A

@zero-24
Copy link
Contributor

zero-24 commented May 21, 2017

hmm. did i something wrong?

To me it looks like:
image

@mbabker
Copy link
Contributor Author

mbabker commented May 21, 2017

We just had even more static tracking in the helper than I accounted for. Should be fine now.

@zero-24
Copy link
Contributor

zero-24 commented May 21, 2017

I have tested this item ✅ successfully on 6823e49

looks good to me. Thanks @mbabker

@iv660 and @franz-wohlkoenig can you take a look here? Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607.

@ghost
Copy link

ghost commented May 21, 2017

@zero-24 didn't understand anything.

@zero-24
Copy link
Contributor

zero-24 commented May 21, 2017

@franz-wohlkoenig may you found some time to test this as you commented on the other issue too ;)

@ghost
Copy link

ghost commented May 21, 2017

@zero-24 i asked if Issue is on latest staging too;-)

@alikon
Copy link
Contributor

alikon commented Jun 17, 2017

I have tested this item ✅ successfully on 414a26b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jun 17, 2017
@rdeutz rdeutz added this to the Joomla 3.7.4 milestone Jun 21, 2017
@rdeutz rdeutz merged commit 46a7bf4 into joomla:staging Jul 5, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 5, 2017
@mbabker mbabker deleted the unique-dispatcher branch July 5, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants