-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track plugins being loaded to unique dispatchers #15607
Conversation
We just had even more static tracking in the helper than I accounted for. Should be fine now. |
I have tested this item ✅ successfully on 6823e49 @iv660 and @franz-wohlkoenig can you take a look here? Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607. |
@zero-24 didn't understand anything. |
@franz-wohlkoenig may you found some time to test this as you commented on the other issue too ;) |
@zero-24 i asked if Issue is on latest staging too;-) |
I have tested this item ✅ successfully on 414a26b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15607. |
Pull Request for Issue #12690
Summary of Changes
JPluginHelper::importPlugin()
has a static tracking array that only allows a plugin to be loaded once, preventing the ability for plugins to be registered to anything but the first dispatcher that gets used. Change the method to track loaded plugins based on the dispatcher to allow custom imports.Testing Instructions
See the issue for more information.
Expected result
Plugins imported to each unique dispatcher.
Actual result
Plugins are only loaded to the first dispatcher (generally the singleton from
JEventDispatcher::getInstance()
).Documentation Changes Required
N/A