-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Check for existence of parse_ini_file at installation time #15619
Conversation
first part of fixing #15587 is to not allow new installations of Joomla that dont meet the minimum requirements (E.g. parse_ini_file is required for Joomla, therefore cannot be disabled
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Imho we can't make it a requirement in J3, but we should in J4. However we can show it as a recommend setting for J3 |
I have tested this item ✅ successfully on 4d99cda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15619. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15619. |
This comment was marked as abuse.
This comment was marked as abuse.
changed to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15619. |
I am the one who pointed to this issue and the solution in the maintainers chat. I take off RTC indeed ( was too fast) as you used The case we have is with people who do have parse_ini_string but not parse_ini_file, therefore please upgrade this PR to fit. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Wrong imho, we still need to inform people at Installation time that something is wrong concerning their parse_ini whether it is file OR string. |
If you change https://github.com/PhilETaylor/joomla-cms/blob/4d99cdaa107ac8242d87809646697322ea53b722/installation/model/setup.php#L291 to have a non-null value then when |
Don't forget that a large percentage of new installation are not created with the installer |
Ya well we can only cater for what we can control. Even if we revert the "hard" requirement, having the check raise a notice if one of the two are missing would be good. That said, it should probably hard fail if both are missing unless we're willing to accept the dependency to the FOF code, which it seems some aren't willing to use a library we ship within core. |
This comment was marked as abuse.
This comment was marked as abuse.
Crazy to ship AND Use a library but prevent it's use |
It is used |
This comment was marked as abuse.
This comment was marked as abuse.
I tested in real world and Any other debate concerns #15620 |
I have tested this item ✅ successfully on 4d99cda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15619. |
To my knowledge we required the |
This comment was marked as abuse.
This comment was marked as abuse.
The reason was likely that you can use one function call instead of several and you don't need to do the QQ string replacing as |
No need to merge this as #15620 has been merged. Let's consider it for 4.0 with some changes including new lang string AND default to hardcoded English phrase as otherwise user may only get the constant: Concerning update, we may also need to do something generally speaking, for example displaying after update a hardcoded error specifying the issue. |
Even with #15620 merged this should still go into 3.x in some form. Right now our install checks are only looking for |
@mbabker |
first part of fixing #15587 is to not allow new installations of Joomla that dont meet the minimum requirements (E.g. parse_ini_file is required for Joomla, therefore cannot be disabled
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required