[4.0] Re-installing languages broken

[infograf768]

Steps to reproduce the issue

Install a language through Installation->Install->Upload package file.
for example pick https://github.com/infograf768/fr-FR-3.x/releases/download/3.7.0.2_stable/fr-FR_joomla_lang_full_3.7.0v2.zip

Then re-install it the same way.
One gets:
0 - An error has occurred.
Call to undefined method JInstallerAdapterLanguage::set()

Note: First install works fine as well as uninstall the pack

[mbabker]

The install adapters don't extend from JObject anymore so get/set aren't there. Though I swear when I did that change I caught all of the uses...

[Bakual]

Installing a language from the language installer is indeed broken currently. It uses the "Install from URL" method. From what I debugged so far, the response from JHttpTransportCurl->get($url) is wrong. It does contain the header but no code and body property and thus afterwards everything fails.

It may be related to #13936 (not sure).

[mbabker]

There won't be an explicit body or code property anymore, but calling $response->body should still give the body contents through our magic getter and B/C layer.

[Bakual]

Thanks. Have to debug bit more then 😊

[Bakual]

Btw, same issue in J3.8 for me.

[laoneo]

Can this be the cause #15884?

[Bakual]

I don't think it's related to that. It seems to run through all but in the end I get "Error
Unable to find install package"
It also doesn't work in the installation step where you could add more languages.

[Bakual]

@infograf768 Can you confirm that this is the same issue as yours? And that it also doesn't work in 3.8?
If so, then this will be a release blocker for 3.8.0.

[wilsonge]

There is a pull request with #16300

[Bakual]

Apparently we have two issues as it looks. Will open a new one for the remaining.

[wilsonge]

Thankyou!

[Bakual]

Actually, I'm just stupid. The XML has <targetplatform name="joomla" version="3.[01234567]"/> and thus currently in 3.8 and 4.0 no matching language pack will be found.

[brianteeman]

@Bakual was just about to point that out - glad you spotted it yourself