Bug: Correcting category associations #15664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grace to Bakual, we do not lose anymore the association in category view. |
Bakual
reviewed
Apr 28, 2017
| @@ -36,7 +36,7 @@ public static function getAssociations($id = 0, $view = null) | |||
| $view = $view === null ? $jinput->get('view') : $view; | |||
| $id = empty($id) ? $jinput->getInt('id') : $id; | |||
|
|
|||
| if ($view === 'article' || $view === 'category' || $view === 'featured') | |||
| if ($view === 'article') | |||
There was a problem hiding this comment.
I don't think you should remove the || $view === 'featured' here. Only the category case needs to be gone.
There was a problem hiding this comment.
Judging from code it could break if the current view is "featured". But I wasn't able to find a way to break it, so you may be right that it is not needed 👍
|
I have tested this item ✅ successfully on effd40c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15664. |
|
I have tested this item ✅ successfully on effd40c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15664. |
|
RTC after two successful tests. |
rdeutz
pushed a commit
to joomlajenkins/joomla-cms
that referenced
this pull request
May 1, 2017
* Bug: Correcting category associations * Thanks, Thomas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #15612
Summary of Changes
Correcting faulty code in #12042
Testing Instructions
Create a multilingual site (2 languages is enough)
Create a new article category for each language. Associate these new categories.
Create an article in each of these new categories. Tagged to the same language.
In the mainmenu for one of the languages, create a new menu item of type category list displaying the new category tagged to the same language as the Home page of that menu.
In frontend, display this menu item. Using the language switcher, click on the flag of the other language
Before patch
Clicking on that flag will display the home page of that language.
After patch
The associated category will display correctly.
@oliver-74
Please confirm on issues.joomla.org
@Bakual
This patch makes us lose the possible associated flag next to associated articles when displaying a blog or a category list. We do keep it OK when the view is
articleorfeatured.Any way you see to not lose the feature for category views?