stats plugin text #15735
Merged
stats plugin text #15735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
May 4, 2017
| @@ -24,7 +24,7 @@ PLG_SYSTEM_STATS_MODE_OPTION_ALWAYS_SEND="Always send" | |||
| PLG_SYSTEM_STATS_MODE_OPTION_NEVER_SEND="Never send" | |||
| PLG_SYSTEM_STATS_MODE_OPTION_ON_DEMAND="On demand" | |||
| PLG_SYSTEM_STATS_MSG_ALLOW_SENDING_DATA="Enable Joomla Statistics?" | |||
| PLG_SYSTEM_STATS_MSG_JOOMLA_WANTS_TO_SEND_DATA="In order to better understand our install base and end user environments, this plugin has been created to send those statistics back to a Joomla! controlled central server. No identifying data is captured at any point. You can change these settings later from Plugins > System - Joomla! Statistics." | |||
| PLG_SYSTEM_STATS_MSG_JOOMLA_WANTS_TO_SEND_DATA="In order to better understand our install base and end user environments it is helpful if you send some site information back to a Joomla! controlled central server. No identifying data is captured at any point. You can change these settings later from Plugins > System - Joomla! Statistics." | |||
There was a problem hiding this comment.
I would put a comma after environments, otherwise, it looks good.
There was a problem hiding this comment.
there is no need for the comma
|
I have tested this item ✅ successfully on f3f7ed4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15735. |
1 similar comment
|
I have tested this item ✅ successfully on f3f7ed4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15735. |
|
RTC after two successful tests. |
joomla-cms-bot
added
Language Change
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the text of the message
specifically it is wrong to say "this plugin" in the context of where the message is displayedd